Add external_openstack_enable_ingress_hostname option for external-openstack-cloud-controller-manager

[chnyda]

Signed-off-by: Cedric Hnyda cedric.hnyda@itera.io

What type of PR is this?

/kind feature

What this PR does / why we need it:

A new config option enable-ingress-hostname was introduced to fix issues related to broken headers with PROXY protocol enabled (kubernetes/cloud-provider-openstack#1449)
In PROXY mode, set Hostname field using IP address and a suffix .nip.io to expose the Service of LoadBalancer type if enable-ingress-hostname is enabled.

The PR adds the option in kubespray: external_openstack_enable_ingress_hostname

Which issue(s) this PR fixes:
Solving kubernetes/ingress-nginx#3996 and kubernetes/kubernetes#66607

[k8s-ci-robot]

Hi @chnyda. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oomichi]

Most part seems good for me, just one comment.

/cc @oomichi

[oomichi]

Could you add the default value of this option into roles/kubespray-defaults/defaults/main.yaml ?
We can see default values of external_openstack_* on the file like

# Default values for the external OpenStack Cloud Controller
external_openstack_lbaas_create_monitor: false
external_openstack_lbaas_monitor_delay: "1m"
external_openstack_lbaas_monitor_timeout: "30s"
external_openstack_lbaas_monitor_max_retries: "3" 
external_openstack_network_ipv6_disabled: false
external_openstack_lbaas_use_octavia: false
external_openstack_network_internal_networks: []
external_openstack_network_public_networks: []

[chnyda]

Good point @oomichi. Added.

[oomichi]

/ok-to-test

[oomichi]

Thanks for updating.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chnyda, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment