Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico wireguard #7638

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Calico wireguard #7638

merged 2 commits into from
Jun 25, 2021

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented May 21, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds support for enabling Wireguard encryption when deploying Kubespray with Calico.

Which issue(s) this PR fixes:

Fixes #7637

Special notes for your reviewer:
This PR requires changes coming in from #7618 and should be rebased and merged after that one is merged.

Does this PR introduce a user-facing change?:

Calico: add Wireguard support

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 21, 2021
@cristicalin cristicalin marked this pull request as draft May 21, 2021 10:02
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten May 21, 2021 10:02
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2021
@cristicalin cristicalin force-pushed the calico_wireguard branch 6 times, most recently from 1258fc1 to a9927d3 Compare May 25, 2021 15:20
@cristicalin cristicalin marked this pull request as ready for review June 7, 2021 17:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2021
@cristicalin
Copy link
Contributor Author

With #7618 now merged this is now ready for review.

cristiklein
cristiklein approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the minor nit-pick, this looks visually sound. I'm hoping to get some time to set up a brand new cluster in a few days, and I will use that opportunity to test this PR. No promises though. 😄

roles/network_plugin/calico/defaults/main.yml
# Calico Wireguard support
calico_wireguard_enabled: false
calico_wireguard_packages: []
calico_wireguard_repo: https://download.copr.fedorainfracloud.org/results/jdoss/wireguard/epel-{{ ansible_distribution_major_version }}-$basearch/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick: Should this be calico_wireguard_fedora_repo or calico_wireguard_epel_repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by CentOS and some derivatives (think Alma and Amazon) and is not tied to EPEL. This repo contains the wireguard-dkms kernel module while the wireguard-tools comes from EPEL (seems that non-Debian distro's are all over the map on this one).

Debian, Ubuntu, OpenSUSE Leap and Oracle Linux actually contain both wireguard-tools and wireguard-dkms packages in their main repos and are a bit more sound.

This is my reasoning for the variable naming.

@cristiklein cristiklein mentioned this pull request Jun 9, 2021
Closed
@cristiklein
Copy link
Contributor

I just tired this branch out and it works like a charm. Traffic is definitely encrypted via WireGuard.

Could you document this value in k8s-net-calico.yml?

@cristicalin cristicalin force-pushed the calico_wireguard branch 2 times, most recently from 62c985b to b8d0617 Compare June 11, 2021 04:38
@cristicalin
Copy link
Contributor Author

@cristiklein done

floryut
floryut approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@floryut floryut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
Looks fine to me indeed, good work on this one

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, cristiklein, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021
@cristicalin cristicalin force-pushed the calico_wireguard branch 2 times, most recently from a544865 to b480572 Compare June 18, 2021 18:01
@oomichi
Copy link
Contributor

oomichi commented Jun 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2021
@cristicalin
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit a2cf681 into kubernetes-sigs:master Jun 25, 2021
@floryut floryut mentioned this pull request Sep 8, 2021
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@cristicalin @LuckySB
Calico wireguard (kubernetes-sigs#7638)
13cebc7 
* Calico: add Wireguard support

* CI: Add Calico Wireguard scenario
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@cristicalin @sakuraiyuta
Calico wireguard (kubernetes-sigs#7638)
5b602a0 
* Calico: add Wireguard support

* CI: Add Calico Wireguard scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@cristiklein cristiklein cristiklein approved these changes

@EppO EppO Awaiting requested review from EppO

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Calico Wireguard support
5 participants
@cristicalin @k8s-ci-robot @cristiklein @oomichi @floryut