-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added possibility to specify vSphere credentials via env variables #7646
Added possibility to specify vSphere credentials via env variables #7646
Conversation
Hi @Xartos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request message explains well, and mo part seems good for me.
/cc @oomichi
/ok-to-test
roles/kubernetes-apps/external_cloud_controller/vsphere/defaults/main.yml
Outdated
Show resolved
Hide resolved
Thanks for updating. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, Xartos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubernetes-sigs#7646) * Added possibility to specify vSphere credentials via env variables * Removed excessive spacing
…ubernetes-sigs#7646) * Added possibility to specify vSphere credentials via env variables * Removed excessive spacing
What type of PR is this?
What this PR does / why we need it:
Since the vSphere password variable is in the plain text config file, it's very easy for a user to set it in plain-text while testing which might lead to unwanted consequences.
To be able to easily set sensitive credentials via other methods than from config we should be able to set it via environment variables.
This is already the case if you use
--extra-vars foo=${BAR}
but to make this process more straight forward I suggest we add this variable which wouldn't change the current behavior.I used same approach as openstack and same naming convention as the official terraform module
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?: