-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx-ingress: bump to 1.0.0 to support kube 1.22 #7942
nginx-ingress: bump to 1.0.0 to support kube 1.22 #7942
Conversation
Hi @cristicalin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c877278
to
9d2c8e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristicalin You're on fire man, thanks a lot
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@cristicalin Should we mention somewhere that nginx-ingress 1.0 has a breaking change? Someone , during upgrade cluster with master branch of kubespray, might think: "I upgrade cluster just to kubernetes v1.21 which still support networking.k8s.io/v1beta object " . And it will break the cluster, because nginx-ingress 1.0 does not support networking.k8s.io/v1beta . |
I'll keep that in mind for the release note |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The nginx ingress controller stopped working with Kubernetes 1.22 with the deprecation of the
v1beta1
and move to the stable APInetworking.k8s.io
. Subsequently a new version of the nginx-ingress controller was released (https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.0.0) that supports the stable API down to kubernetes 1.19.This PR moves our nginx-ingress controller to 1.0.0 to support all versions of kubernetes currently supported in kubespray master branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: