Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx-ingress: bump to 1.0.0 to support kube 1.22 #7942

Merged

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Sep 4, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:
The nginx ingress controller stopped working with Kubernetes 1.22 with the deprecation of the v1beta1 and move to the stable API networking.k8s.io. Subsequently a new version of the nginx-ingress controller was released (https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.0.0) that supports the stable API down to kubernetes 1.19.
This PR moves our nginx-ingress controller to 1.0.0 to support all versions of kubernetes currently supported in kubespray master branch.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ingress-nginx: upgrade to 1.0.0 with stable ingress API, this version requires explicitly setting `kubernetes.io/ingress.class: nginx` on managed ingresses

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cristicalin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and oomichi September 4, 2021 23:08
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristicalin You're on fire man, thanks a lot
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2021
@champtar
Copy link
Contributor

champtar commented Sep 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 43e7e2d into kubernetes-sigs:master Sep 6, 2021
@cloud-66
Copy link
Contributor

cloud-66 commented Sep 7, 2021

@cristicalin Should we mention somewhere that nginx-ingress 1.0 has a breaking change? Someone , during upgrade cluster with master branch of kubespray, might think: "I upgrade cluster just to kubernetes v1.21 which still support networking.k8s.io/v1beta object " . And it will break the cluster, because nginx-ingress 1.0 does not support networking.k8s.io/v1beta .

@floryut
Copy link
Member

floryut commented Sep 8, 2021

I'll keep that in mind for the release note

@cristicalin
Copy link
Contributor Author

cristicalin commented Sep 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants