Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kube_config_dir for kubeconfig #7996

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

oomichi
Copy link
Contributor

@oomichi oomichi commented Sep 21, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

The path of kubeconfig should be configurable, and its default value is /etc/kubernetes/admin.conf.
Most paths of the file are configurable but some were not.
This make those configurable.

Does this PR introduce a user-facing change?:

Use `kube_config_dir` for kubeconfig instead of hard path in multiple plays

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
@floryut floryut added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/bug Categorizes issue or PR as related to a bug. labels Sep 21, 2021
@floryut
Copy link
Member

floryut commented Sep 21, 2021

I guess we could also update paths in

{{ bin_dir }}/kubeadm --kubeconfig /etc/kubernetes/admin.conf token delete {{ kubeadm_token }} || :;
{{ bin_dir }}/kubeadm --kubeconfig /etc/kubernetes/admin.conf token create {{ kubeadm_token }}
changed_when: false
when:
- inventory_hostname == groups['kube_control_plane']|first
- kubeadm_token is defined
- kubeadm_refresh_token
tags:
- kubeadm_token
- name: Create kubeadm token for joining nodes with 24h expiration (default)
command: "{{ bin_dir }}/kubeadm --kubeconfig /etc/kubernetes/admin.conf token create"

And in
--kubeconfig /etc/kubernetes/admin.conf

The path of kubeconfig should be configurable, and its default value
is /etc/kubernetes/admin.conf. Most paths of the file are configurable
but some were not. This make those configurable.
@oomichi oomichi force-pushed the use-kube_config_dir branch from 72aabcc to 39728a5 Compare September 21, 2021 22:39
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2021
@oomichi
Copy link
Contributor Author

oomichi commented Sep 21, 2021

@floryut Thank you for your review, that is a nice point.
I updated the pull request based on your point.

@floryut floryut added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 843252c into kubernetes-sigs:master Sep 23, 2021
rtsp pushed a commit to rtsp/kubespray that referenced this pull request Sep 23, 2021
The path of kubeconfig should be configurable, and its default value
is /etc/kubernetes/admin.conf. Most paths of the file are configurable
but some were not. This make those configurable.
oomichi added a commit to oomichi/kubespray that referenced this pull request Sep 29, 2021
The path of kubeconfig should be configurable, and its default value
is /etc/kubernetes/admin.conf. Most paths of the file are configurable
but some were not. This make those configurable.
k8s-ci-robot pushed a commit that referenced this pull request Sep 30, 2021
The path of kubeconfig should be configurable, and its default value
is /etc/kubernetes/admin.conf. Most paths of the file are configurable
but some were not. This make those configurable.
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
The path of kubeconfig should be configurable, and its default value
is /etc/kubernetes/admin.conf. Most paths of the file are configurable
but some were not. This make those configurable.
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
The path of kubeconfig should be configurable, and its default value
is /etc/kubernetes/admin.conf. Most paths of the file are configurable
but some were not. This make those configurable.
huangkevin404 pushed a commit to wiremind/kubespray that referenced this pull request Sep 15, 2022
…-sigs#8037)

The path of kubeconfig should be configurable, and its default value
is /etc/kubernetes/admin.conf. Most paths of the file are configurable
but some were not. This make those configurable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants