Fix containerd failed to start if apparmor is not installed #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
Hi @rtsp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
rtsp
force-pushed
the
develop/install-apparmor
branch
from
4a1d321 to
a3fd370
Compare
Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var.
rtsp
force-pushed
the
develop/install-apparmor
branch
from
a3fd370 to
df05ba3
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
floryut
approved these changes
Sep 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, rtsp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
rtsp
added a commit
to rtsp/kubespray
that referenced
this pull request
Oct 1, 2021
Backport kubernetes-sigs#8011 and kubernetes-sigs#8036 to kubespray/release-2.17
sathieu
pushed a commit
to sathieu/kubespray
that referenced
this pull request
Oct 1, 2021
Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var. (cherry picked from commit 4bace24)
|
Done in #8042. |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Oct 1, 2021
…8042) * Ensure apparmor is installed (#8011) Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var. (cherry picked from commit 4bace24) * Ensure apparmor is installed (#8036) Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var. (cherry picked from commit af04906) Co-authored-by: rtsp <git@rtsp.us>
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2021
Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var.
Closed
7 tasks
otani88
pushed a commit
to velas/kubespray
that referenced
this pull request
Mar 5, 2022
…ubernetes-sigs#8042) * Ensure apparmor is installed (kubernetes-sigs#8011) Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var. (cherry picked from commit 4bace24) * Ensure apparmor is installed (kubernetes-sigs#8036) Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var. (cherry picked from commit af04906) Co-authored-by: rtsp <git@rtsp.us>
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
Kubespray deployment failed when using containerd backend on nodes that apparmor was not installed or previously removed. This PR ensure apparmor is installed by adding it into required_pkgs var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Kubespray deployment failed when using
containerdbackend on nodes thatapparmorwas not installed or previously removed.This PR ensure apparmor is installed by adding it into
required_pkgsvar.Which issue(s) this PR fixes:
Fixes #7965
Special notes for your reviewer:
I've added
apparmorto both variable files but I only tested on Debian 11. If this patch break Debian 10 pipeline (it shouldn't) I will remove this line fromdebian.yml.Does this PR introduce a user-facing change?: