-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubeadm_join_phases_skip variable #8067
Add kubeadm_join_phases_skip variable #8067
Conversation
Hi @necatican. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To keep this inline with the 👍 for spotting this issue |
Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
4ca7a4d
to
eb48dfb
Compare
Thank you for the ideas and for the better documentation. 🙂 I've added the |
…c with kubeadm_init_phases_skip
eb48dfb
to
62a4465
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Good idea 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, necatican The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Add kubeadm_join_phases_skip variable * Update kubeadm_join_phases_skip comment Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com> * Add kubeadm_join_phases_skip_default variable to follow the same logic with kubeadm_init_phases_skip Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
* Add kubeadm_join_phases_skip variable * Update kubeadm_join_phases_skip comment Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com> * Add kubeadm_join_phases_skip_default variable to follow the same logic with kubeadm_init_phases_skip Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows users to be able to skip some phases in the join_phase using
kubeadm_join_phases_skip
.We already have a variable (
kubeadm_init_phases_skip
) to skip init phases. Another one for the join phases would be beneficial.Which issue(s) this PR fixes:
Fixes #8066
Special notes for your reviewer:
Does this PR introduce a user-facing change?: