Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubeadm_join_phases_skip variable #8067

Merged

Conversation

necatican
Copy link
Contributor

@necatican necatican commented Oct 9, 2021

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows users to be able to skip some phases in the join_phase using kubeadm_join_phases_skip.

We already have a variable (kubeadm_init_phases_skip) to skip init phases. Another one for the join phases would be beneficial.

Which issue(s) this PR fixes:

Fixes #8066

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add the ability to skip some phases in the kubeadm join_phase using `kubeadm_join_phases_skip`

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @necatican. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and holmsten October 9, 2021 19:08
@cristicalin
Copy link
Contributor

To keep this inline with the kubeadm_init_phases_skip_default naming option, maybe it's better to follow the same logic and expose kubeadm_join_phases_skip_default as the user facing variable and compile kubeadm_join_phases_skip from joining a currently empty list (with the option to extend it later if we discover the need) with the contents of kubeadm_join_phases_skip_default.

👍 for spotting this issue

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
@necatican necatican force-pushed the kubeadm-join-phases-skip branch 2 times, most recently from 4ca7a4d to eb48dfb Compare October 10, 2021 09:35
@necatican
Copy link
Contributor Author

To keep this inline with the kubeadm_init_phases_skip_default naming option, maybe it's better to follow the same logic and expose kubeadm_join_phases_skip_default as the user facing variable and compile kubeadm_join_phases_skip from joining a currently empty list (with the option to extend it later if we discover the need) with the contents of kubeadm_join_phases_skip_default.

👍 for spotting this issue

Thank you for the ideas and for the better documentation. 🙂 I've added the kubeadm_join_phases_skip_default variable.

@necatican necatican force-pushed the kubeadm-join-phases-skip branch from eb48dfb to 62a4465 Compare October 10, 2021 13:00
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
Good idea 👍

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, necatican

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@oomichi
Copy link
Contributor

oomichi commented Oct 11, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1a57780 into kubernetes-sigs:master Oct 11, 2021
@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 12, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* Add kubeadm_join_phases_skip variable

* Update kubeadm_join_phases_skip comment

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* Add kubeadm_join_phases_skip_default variable to follow the same logic with kubeadm_init_phases_skip

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 27, 2023
* Add kubeadm_join_phases_skip variable

* Update kubeadm_join_phases_skip comment

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* Add kubeadm_join_phases_skip_default variable to follow the same logic with kubeadm_init_phases_skip

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kubeadm_join_phases_skip to skip phases when joining the cluster
5 participants