Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Ambassador ingress code #8086

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

floryut
Copy link
Member

@floryut floryut commented Oct 15, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Ambassador is no longer maintained and is not working anymore.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
See discussion #6135 (comment)
And issue in ambassador repo here datawire/ambassador-operator#73

Does this PR introduce a user-facing change?:

[Ambassador] Remove code, ci and ansible tags as it's no longer maintained and not working anymore.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2021
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO October 15, 2021 09:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 15, 2021
@floryut
Copy link
Member Author

floryut commented Oct 15, 2021

@aztechian let's wait a few days/week before merging this one, but I'm preparing it as I don't have a lot of hope ;)

@aztechian
Copy link
Contributor

Agreed. Sounds good.
Just to confirm - this change won't remove an ambassador install from an existing cluster, correct?

@floryut
Copy link
Member Author

floryut commented Oct 18, 2021

Agreed. Sounds good. Just to confirm - this change won't remove an ambassador install from an existing cluster, correct?

Nop it won't, the ingress_ambassador_enabled key will be ignored if set.

@floryut floryut added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 21, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2021
@floryut floryut marked this pull request as ready for review October 25, 2021 11:39
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 25, 2021
@floryut
Copy link
Member Author

floryut commented Oct 25, 2021

/cc @aztechian @oomichi @EppO
Let's remove.. no answer on datawire end, no issue/pr for more than 6 months, I'd say that this is no longer maintained.

@k8s-ci-robot k8s-ci-robot requested a review from oomichi October 25, 2021 11:40
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Oct 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aztechian, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oomichi
Copy link
Contributor

oomichi commented Oct 26, 2021

/cc @aztechian @oomichi @EppO Let's remove.. no answer on datawire end, no issue/pr for more than 6 months, I'd say that this is no longer maintained.

Sounds reasonable to remove the Ambassador ingress for me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 331647f into kubernetes-sigs:master Oct 26, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants