-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert numbers to string for calico's inventory check. #8120
Conversation
Fix #8119 Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
Welcome @juliohm1978! |
Hi @juliohm1978. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pr |
@@ -53,7 +53,7 @@ | |||
- name: "Check if inventory match current cluster configuration" | |||
assert: | |||
that: | |||
- calico_pool_conf.spec.blockSize == (calico_pool_blocksize | default(kube_network_node_prefix)) | |||
- calico_pool_conf.spec.blockSize|string == (calico_pool_blocksize | default(kube_network_node_prefix | string)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this value is supposed to be an integer why not use | int
instead of | string
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent point. PR was approved before I had the chance to get back to this :)
But I guess the end result is the same.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, juliohm1978 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@juliohm1978 Thanks for the PR 👍 |
…rnetes-sigs#8120)" This reverts commit d42b722.
…igs#8120) Fix kubernetes-sigs#8119 Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
…igs#8120) Fix kubernetes-sigs#8119 Signed-off-by: Julio Morimoto <julio@morimoto.net.br>
Signed-off-by: Julio Morimoto julio@morimoto.net.br
What type of PR is this?
/kind bug
What this PR does / why we need it:
Calico inventory checks do not always work as expected.
Which issue(s) this PR fixes:
Fixes #8119
Does this PR introduce a user-facing change?: