Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx ingress controller should watch kind:ingress without class #8128

Merged
merged 1 commit into from
Oct 28, 2021
Merged

nginx ingress controller should watch kind:ingress without class #8128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...rnetes-apps/ingress_controller/ingress_nginx/templates/ds-ingress-nginx-controller.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ spec:
- --annotations-prefix=nginx.ingress.kubernetes.io
{% if ingress_nginx_class is defined %}
- --ingress-class={{ ingress_nginx_class }}
{% else %}
- --watch-ingress-without-class=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As https://kubernetes.github.io/ingress-nginx/#i-have-multiple-ingress-objects-in-my-cluster-what-should-i-do

If you don't care about ingressClass, or you have a lot of ingress objects without
ingressClass configuration, you can run the ingress-controller with the flag
--watch-ingress-without-class=true

this seems good for me.

{% endif %}
{% if ingress_nginx_host_network %}
- --report-node-internal-ip-address
Expand Down