Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: replace the use of containerd_version with docker_containerd_version #8130

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/upgrades.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ You can also individually control versions of components by explicitly defining
versions. Here are all version vars for each component:

* docker_version
* containerd_version
* docker_containerd_version (relevant when `container_manager` == `docker`)
* containerd_version (relevant when `container_manager` == `containerd`)
* kube_version
* etcd_version
* calico_version
Expand Down
3 changes: 2 additions & 1 deletion docs/vars.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ Some variables of note include:
* *docker_version* - Specify version of Docker to used (should be quoted
string). Must match one of the keys defined for *docker_versioned_pkg*
in `roles/container-engine/docker/vars/*.yml`.
* *containerd_version* - Specify version of Containerd to use
* *containerd_version* - Specify version of containerd to use when setting `container_manager` to `containerd`
* *docker_containerd_version* - Specify which version of containerd to use when setting `container_manager` to `docker`
* *etcd_version* - Specify version of ETCD to use
* *ipip* - Enables Calico ipip encapsulation by default
* *kube_network_plugin* - Sets k8s network plugin (default Calico)
Expand Down
2 changes: 1 addition & 1 deletion roles/container-engine/docker/vars/debian-stretch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ docker_cli_versioned_pkg:

docker_package_info:
pkgs:
- "{{ containerd_versioned_pkg[containerd_version | string] }}"
- "{{ containerd_versioned_pkg[docker_containerd_version | string] }}"
- "{{ docker_cli_versioned_pkg[docker_cli_version | string] }}"
- "{{ docker_versioned_pkg[docker_version | string] }}"

Expand Down
2 changes: 1 addition & 1 deletion roles/container-engine/docker/vars/debian.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ docker_cli_versioned_pkg:

docker_package_info:
pkgs:
- "{{ containerd_versioned_pkg[containerd_version | string] }}"
- "{{ containerd_versioned_pkg[docker_containerd_version | string] }}"
- "{{ docker_cli_versioned_pkg[docker_cli_version | string] }}"
- "{{ docker_versioned_pkg[docker_version | string] }}"

Expand Down
2 changes: 1 addition & 1 deletion roles/container-engine/docker/vars/fedora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ docker_cli_versioned_pkg:
docker_package_info:
enablerepo: "docker-ce"
pkgs:
- "{{ containerd_versioned_pkg[containerd_version | string] }}"
- "{{ containerd_versioned_pkg[docker_containerd_version | string] }}"
- "{{ docker_cli_versioned_pkg[docker_cli_version | string] }}"
- "{{ docker_versioned_pkg[docker_version | string] }}"
2 changes: 1 addition & 1 deletion roles/container-engine/docker/vars/redhat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ docker_cli_versioned_pkg:
docker_package_info:
enablerepo: "docker-ce"
pkgs:
- "{{ containerd_versioned_pkg[containerd_version | string] }}"
- "{{ containerd_versioned_pkg[docker_containerd_version | string] }}"
- "{{ docker_cli_versioned_pkg[docker_cli_version | string] }}"
- "{{ docker_versioned_pkg[docker_version | string] }}"
2 changes: 1 addition & 1 deletion roles/container-engine/docker/vars/ubuntu-16.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ docker_cli_versioned_pkg:

docker_package_info:
pkgs:
- "{{ containerd_versioned_pkg[containerd_version | string] }}"
- "{{ containerd_versioned_pkg[docker_containerd_version | string] }}"
- "{{ docker_cli_versioned_pkg[docker_cli_version | string] }}"
- "{{ docker_versioned_pkg[docker_version | string] }}"

Expand Down
2 changes: 1 addition & 1 deletion roles/container-engine/docker/vars/ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ docker_cli_versioned_pkg:

docker_package_info:
pkgs:
- "{{ containerd_versioned_pkg[containerd_version | string] }}"
- "{{ containerd_versioned_pkg[docker_containerd_version | string] }}"
- "{{ docker_cli_versioned_pkg[docker_cli_version | string] }}"
- "{{ docker_versioned_pkg[docker_version | string] }}"

Expand Down
4 changes: 0 additions & 4 deletions roles/download/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -447,18 +447,14 @@ nerdctl_archive_checksums:
amd64:
0.12.1: 868dc5997c3edb0bd06f75012e71c2b15ee0885b83bad191fbe2a1d6d5f4f2ac

# TODO(cristicalin): remove compatibility entries once debian9 and ubuntu16 jobs are dropped or docker is dropped
containerd_archive_checksums:
arm:
latest: 0 # this is needed to make debian9 and ubuntu16 CI jobs happy
1.4.9: 0
1.5.5: 0
arm64:
latest: 0 # this is needed to make debian9 and ubuntu16 CI jobs happy
1.4.9: 0
1.5.5: 0
amd64:
latest: 0 # this is needed to make debian9 and ubuntu16 CI jobs happy
1.4.9: 346f88ad5b973960ff81b5539d4177af5941ec2e4703b479ca9a6081ff1d023b
1.5.5: 8efc527ffb772a82021800f0151374a3113ed2439922497ff08f2596a70f10f1

Expand Down
5 changes: 4 additions & 1 deletion roles/kubespray-defaults/defaults/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -330,10 +330,13 @@ docker_plugins: []
# Experimental kubeadm etcd deployment mode. Available only for new deployment
etcd_kubeadm_enabled: false

# Containerd options
# Containerd options - thse are relevant when container_manager == 'containerd'
containerd_version: 1.4.9
containerd_use_systemd_cgroup: true

# Docker options - this is relevant when container_manager == 'docker'
docker_containerd_version: 1.4.9

# Settings for containerized control plane (etcd/kubelet/secrets)
# deployment type for legacy etcd mode
etcd_deployment_type: docker
Expand Down
2 changes: 1 addition & 1 deletion tests/files/packet_debian9-calico-upgrade-once.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ dns_min_replicas: 1
download_run_once: true

# Make docker happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_debian9-calico-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ deploy_netchecker: true
dns_min_replicas: 1

# Make docker happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_debian9-macvlan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ macvlan_interface: "eth0"
auto_renew_certificates: true

# Make docker happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_ubuntu16-canal-kubeadm-ha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ deploy_netchecker: true
dns_min_replicas: 1

# Make docker jobs happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_ubuntu16-canal-sep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ deploy_netchecker: true
dns_min_replicas: 1

# Make docker jobs happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_ubuntu16-flannel-ha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ deploy_netchecker: true
dns_min_replicas: 1

# Make docker jobs happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_ubuntu16-kube-router-sep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ deploy_netchecker: true
dns_min_replicas: 1

# Make docker jobs happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_ubuntu16-kube-router-svc-proxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ dns_min_replicas: 1
kube_router_run_service_proxy: true

# Make docker jobs happy
containerd_version: latest
docker_containerd_version: latest
2 changes: 1 addition & 1 deletion tests/files/packet_ubuntu16-weave-sep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ dns_min_replicas: 1
auto_renew_certificates: true

# Make docker jobs happy
containerd_version: latest
docker_containerd_version: latest