-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove-node.yml fix conditional check ansible_os_family #8154
remove-node.yml fix conditional check ansible_os_family #8154
Conversation
fix FAILED! => {"msg": "The conditional check 'ansible_os_family not in [\"Flatcar\", \"Flatcar Container Linux by Kinvolk\"]' failed. The error was: error while evaluating conditional (ansible_os_family not in [\"Flatcar\", \"Flatcar Container Linux by Kinvolk\"]) kubernetes-sigs#8090 kubernetes-sigs#7798 kubernetes-sigs#8009
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @1Const1! |
Hi @1Const1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 1Const1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@1Const1 could you please sign the CLA (https://git.k8s.io/community/CLA.md#the-contributor-license-agreement) ? Also you will need to rebase your PR on the latest master branch since we have been dealing with a couple of CI issues the last two days which have just been fixed. |
Here is the change history related to gather_facts:
I am not sure why #6154 deleted the task. |
Any updates? |
Doesn't #8231 fixes this ? |
fix FAILED! => {"msg": "The conditional check 'ansible_os_family not in ["Flatcar", "Flatcar Container Linux by Kinvolk"]' failed. The error was: error while evaluating conditional (ansible_os_family not in ["Flatcar", "Flatcar Container Linux by Kinvolk"])
#8090
#7798
#8009
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #8090
Fixes #7798
Fixes #8009
Special notes for your reviewer:
Does this PR introduce a user-facing change?: