-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
krew: update to v0.4.2 #8168
krew: update to v0.4.2 #8168
Conversation
krew release urls changed since v0.4.2, clearly OS type and arch inside the filename. from: https://github.com/kubernetes-sigs/krew/releases/download/v0.4.1/krew.tar.gz to: https://github.com/kubernetes-sigs/krew/releases/download/v0.4.2/krew-linux_amd64.tar.gz define `host_os` like `host_architecture` determine which OS is krew installed at.
Hi @zhengtianbao. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhengtianbao 👍 nicely done
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, zhengtianbao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice work @zhengtianbao , thank you! /lgtm |
krew release urls changed since v0.4.2, clearly OS type and arch inside the filename. from: https://github.com/kubernetes-sigs/krew/releases/download/v0.4.1/krew.tar.gz to: https://github.com/kubernetes-sigs/krew/releases/download/v0.4.2/krew-linux_amd64.tar.gz define `host_os` like `host_architecture` determine which OS is krew installed at.
krew release urls changed since v0.4.2, clearly OS type and arch inside the filename. from: https://github.com/kubernetes-sigs/krew/releases/download/v0.4.1/krew.tar.gz to: https://github.com/kubernetes-sigs/krew/releases/download/v0.4.2/krew-linux_amd64.tar.gz define `host_os` like `host_architecture` determine which OS is krew installed at.
krew release download urls changed since v0.4.2.
from:
https://github.com/kubernetes-sigs/krew/releases/download/v0.4.1/krew.tar.gz
to:
https://github.com/kubernetes-sigs/krew/releases/download/v0.4.2/krew-linux_amd64.tar.gz
Release separated archives for each platform, so we should define
host_os
likehost_architecture
to determine which OS krew will be installed at.What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR upgrades krew to 0.4.2 and support darwin/windows platform.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: