[2.17] Fix kubespray flatcar ansible_os_family and ansible_distribution

[isantospardo]

Cherry-picks commit due to request: #8028 (comment)
Related to #8028
Closes #8180

What type of PR is this?
/kind bug

What this PR does / why we need it:
Compatibility with all flatcar verions as ansible_os_family and ansible_distribution are set to Flatcar instead of to Flatcar Container Linux by Kinvolk for several versions

Which issue(s) this PR fixes:

Cherry-picks commit due to request: #8028 (comment)
Related to #8028
Closes #8180

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Fix kubespray flatcar ansible_os_family and ansible_distribution for backward compatibility

[k8s-ci-robot]

Hi @isantospardo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

Hi @isantospardo , thanks for this fix but you will need to cherry-pick #8034 into your change since our CI was pushed to python 3.10 and that needed extra fixes.

Since we already tagged 2.17.1, I think we will need to bundle a few more backports to tag 2.17.2 to include that fix.

/cc @floryut

[oomichi]

To understand this is a backporting pull request easily

/retitle [2.17] Fix kubespray flatcar ansible_os_family and ansible_distribution

[isantospardo]

/retest

[k8s-ci-robot]

@isantospardo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[isantospardo]

Do you want me to cherry-pick the rest of the commits of v2.17.1? @cristicalin

[cristicalin]

@isantospardo there is no need, the merge process will handle the actual merge but you do need to rebase on the current state of the release-2.17 branch because it also brings in #8153 which was backported earlier.

[isantospardo]

It looks we still have some issues after the rebase @cristicalin

[oomichi]

/ok-to-test
/lgtm

[oomichi]

We might need to cherry-pick 2ed211b

[oomichi]

The cherry-pick is #8210
Let's see the result.

[floryut]

The cherry-pick is #8210 Let's see the result.

All done, please rebase branch release-2.17

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, isantospardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isantospardo]

@oomichi could you add the lgtm again to run the last job?

[oomichi]

Thanks for doing this.

/lgtm

[isantospardo]

One more thing, could you please create a new tag v.2.17.2 with this patch? @oomichi