Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fedora reset #8205

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Nov 18, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:
During the development of #8175 I discovered we have an issue with running reset.yml on Fedora. Since the fix is unrelated for that work, I split this into it's own PR and added a step in the fedora33 job to ensure we don't cause any more breakage.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

Fix reset playbook for Fedora OS

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
We should indeed add reset_check to all OS at least (and CRI maybe)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@oomichi
Copy link
Contributor

oomichi commented Nov 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit acd5185 into kubernetes-sigs:master Nov 19, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* Reset: Fedora uses NetworkManager

* CI: test reset on fedora
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
* Reset: Fedora uses NetworkManager

* CI: test reset on fedora
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants