-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fedora reset #8205
Fix fedora reset #8205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We should indeed add reset_check to all OS at least (and CRI maybe)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* Reset: Fedora uses NetworkManager * CI: test reset on fedora
* Reset: Fedora uses NetworkManager * CI: test reset on fedora
What type of PR is this?
/kind bug
What this PR does / why we need it:
During the development of #8175 I discovered we have an issue with running
reset.yml
on Fedora. Since the fix is unrelated for that work, I split this into it's own PR and added a step in the fedora33 job to ensure we don't cause any more breakage.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: