-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Pre-existing Floating IP for Bastion #8214
Use Pre-existing Floating IP for Bastion #8214
Conversation
Welcome @feber! |
Hi @feber. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@feber Thank you for the PR (and for signing up CLA)
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feber, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* use pre-existing floating IP for bastion * document bastion_fips in readme
* use pre-existing floating IP for bastion * document bastion_fips in readme
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use a pre-existing floating IP for bastion node, instead of creating a new one.
Similar with assigning floating IP for k8s master nodes via
k8s_master_fips
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Should be no.