Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change etcd-events listen port to avoid conflicts #8232

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Change etcd-events listen port to avoid conflicts #8232

merged 1 commit into from
Dec 7, 2021

Conversation

zhengtianbao
Copy link
Member

@zhengtianbao zhengtianbao commented Nov 26, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

There is a confilct of etcd_metrics_port and etcd-events listen_client_port, both of them are 2381.

Which issue(s) this PR fixes:

Fixes #8230

Does this PR introduce a user-facing change?:

Change etcd-events listen port (2381 -> 2383) to avoid conflicts

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zhengtianbao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengtianbao Thank you for the PR 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2021
@floryut
Copy link
Member

floryut commented Nov 26, 2021

@zhengtianbao Sorry but you need to rebase master, otherwise CI won't work

@zhengtianbao
Copy link
Member Author

ok, I'm outside this weekend, I will do it next week🙏

@khatrig
Copy link
Contributor

khatrig commented Nov 29, 2021

@zhengtianbao , Couple of points on defining separate etcd-events cluster.

  • Currently, etcd_metrics_port defaults to 2381, etcd-events will need a separate default port(and a new variable eg. etcd_events_metrics_port default -2383?) to avoid conflicts.
  • etcd-events.env template doesn't have a metrics port defined yet, I'm not sure if etcd-events will support metrics this way.

@zhengtianbao
Copy link
Member Author

@zhengtianbao , Couple of points on defining separate etcd-events cluster.

  • Currently, etcd_metrics_port defaults to 2381, etcd-events will need a separate default port(and a new variable eg. etcd_events_metrics_port default -2383?) to avoid conflicts.
  • etcd-events.env template doesn't have a metrics port defined yet, I'm not sure if etcd-events will support metrics this way.

Thanks for your advice, I think whether etcd-events metrics is supported or not needs to be discussed. If we do need it, then I will submit another PR to implement it.

Copy link
Contributor

@cristicalin cristicalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @zhengtianbao for this change!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, zhengtianbao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a separate etcd metrics URL when using separate etcd events cluster
5 participants