-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change etcd-events listen port to avoid conflicts #8232
Conversation
Hi @zhengtianbao. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhengtianbao Thank you for the PR 👍
/ok-to-test
@zhengtianbao Sorry but you need to rebase master, otherwise CI won't work |
ok, I'm outside this weekend, I will do it next week🙏 |
@zhengtianbao , Couple of points on defining separate etcd-events cluster.
|
Thanks for your advice, I think whether etcd-events metrics is supported or not needs to be discussed. If we do need it, then I will submit another PR to implement it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you @zhengtianbao for this change!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, floryut, zhengtianbao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
There is a confilct of
etcd_metrics_port
and etcd-events listen_client_port, both of them are 2381.Which issue(s) this PR fixes:
Fixes #8230
Does this PR introduce a user-facing change?: