-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tests #8234
Merged
Merged
Cleanup tests #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 26, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 26, 2021
floryut
force-pushed
the
cleanup_tests
branch
from
November 26, 2021 09:25
ae21e9c
to
eb0f3b7
Compare
And suddenly magic happened and vagrant failed :) Nice clean up! /lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Nov 26, 2021
This was referenced Nov 26, 2021
floryut
added
kind/feature
Categorizes issue or PR as related to a new feature.
and removed
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
labels
Nov 28, 2021
Closed
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
* Add Fedora 35 image, support and CI * Cleanup tests and allow_failure for vagrant
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 28, 2023
* Add Fedora 35 image, support and CI * Cleanup tests and allow_failure for vagrant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Cleanup test files to remove duplicate values
Allow failure on vagrant, to speed up CI when "temporary failure in name resolution" magically appears
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: