Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tests #8234

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Cleanup tests #8234

merged 2 commits into from
Nov 26, 2021

Conversation

floryut
Copy link
Member

@floryut floryut commented Nov 26, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Cleanup test files to remove duplicate values
Allow failure on vagrant, to speed up CI when "temporary failure in name resolution" magically appears

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

Add support for Fedora 35

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2021
@cristicalin
Copy link
Contributor

And suddenly magic happened and vagrant failed :)

Nice clean up!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit a5f88e1 into kubernetes-sigs:master Nov 26, 2021
@floryut floryut added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 28, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* Add Fedora 35 image, support and CI

* Cleanup tests and allow_failure for vagrant
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
* Add Fedora 35 image, support and CI

* Cleanup tests and allow_failure for vagrant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants