Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vSphere-CSI: update to 2.4.0 #8295

Merged

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Dec 10, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR bumps the vSphere CSI to 2.4.0.

Which issue(s) this PR fixes:

Fixes #8045

Special notes for your reviewer:
Since I don't actually have a vSphere around to test this and we don't cover this CSI in CI, I would wait for some feedback from the requesters in #8045

Does this PR introduce a user-facing change?:

[vSphere-CSI] Update to 2.4.0

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from EppO and LuckySB December 10, 2021 09:36
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 10, 2021
@cristicalin
Copy link
Contributor Author

/cc @Calvinaud @snowball77

@k8s-ci-robot
Copy link
Contributor

@cristicalin: GitHub didn't allow me to request PR reviews from the following users: Calvinaud, snowball77.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Calvinaud @snowball77

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oomichi
Copy link
Contributor

oomichi commented Dec 10, 2021

Thanks for doing this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2021
@floryut floryut added kind/applications Applications section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 10, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0e969c0 into kubernetes-sigs:master Dec 10, 2021
nmasse-itix pushed a commit to nmasse-itix/kubespray that referenced this pull request Dec 20, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/applications Applications section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Vsphere CSI 2.3.0
4 participants