Fix external lb error

[singeleaf]

What type of PR is this?
/kind bug

What this PR does / why we need it:
At the kube_control_plane node, apiserver_loadbalancer_domain_name should point to dbip

Which issue(s) this PR fixes:
Fixes #8290

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:

Fix `apiserver_loadbalancer_domain_name` pointing to external LB instead of dbip

[k8s-ci-robot]

Hi @singeleaf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

Thanks @singeleaf for this fix!

/ok-to-test
/lgtm

[oomichi]

Thanks for fixing.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, singeleaf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [oomichi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[1Const1]

actually this fix produce new bug that now even external LB is present in all.yml

External LB example config
apiserver_loadbalancer_domain_name: "loadbalancer-kube.example.com"
loadbalancer_apiserver:
  address: 10.0.0.10
  port: 6443

than it writes in control-plane nodes hosts file:
127.0.0.1 loadbalancer-kube.example.com localhost localhost.localdomain

so next what's happened control plane nodes can't connect to external load balancer because ex lb is now localhost

changes:

apiserver_loadbalancer_domain_name_host: |-
  {% if inventory_hostname in groups['kube_control_plane'] -%}
      127.0.0.1
  {%- else -%}
      {{ loadbalancer_apiserver.address }}
  {%- endif %}

kubespray need new fix after that
code was merged and not even tested with lb configuration present

node2 : ok=634 changed=119 unreachable=0 failed=1 skipped=640 rescued=0 ignored=2
node3 : ok=634 changed=119 unreachable=0 failed=1 skipped=640 rescued=0 ignored=2

node1,2,3 - master nodes, so 2 nodes can't connect without lb

before this commit everything working fine with or without loadbalancer