Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identity_allocation_mode support for Cilium #8430

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Add identity_allocation_mode support for Cilium #8430

merged 1 commit into from
Jan 16, 2022

Conversation

necatican
Copy link
Contributor

@necatican necatican commented Jan 14, 2022 •
edited by floryut
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Cilium supports crd and kvstore options to choose how identities are shared between Cilium nodes.
The current Kubespray installation only supports using etcd as kvstore.

Which issue(s) this PR fixes:

Fixes #8355

Special notes for your reviewer:
crd is listed as the default option in the prerequisites. We kept the default value as "kvstore" to avoid introducing user-facing changes.

Does this PR introduce a user-facing change?:

[Cilium] Add identity_allocation_mode support

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @necatican. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2022
@necatican necatican changed the title Add identity_allocation_mode support for Cilium WIP: Add identity_allocation_mode support for Cilium Jan 14, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2022
@necatican necatican force-pushed the feat/cilium-identity-allocation-mode branch from 849d4fc to ca09b54 Compare January 14, 2022 13:28
@necatican
Copy link
Contributor Author

We're having some issues with Hubble. Will remove the WIP tag once we fix those issues.

@necatican necatican force-pushed the feat/cilium-identity-allocation-mode branch from ca09b54 to d23e5c0 Compare January 14, 2022 14:06
@necatican necatican changed the title WIP: Add identity_allocation_mode support for Cilium Add identity_allocation_mode support for Cilium Jan 14, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2022
@necatican @eminaktas @yasinterol
Add identity_allocation_mode support for Cilium
053cfb7 
Co-authored-by: Emin Aktaş <eminaktas34@gmail.com>
Co-authored-by: Yasin Taha Erol <yasintahaerol@gmail.com>
Signed-off-by: necatican <necaticanyildirim@gmail.com>
@necatican necatican force-pushed the feat/cilium-identity-allocation-mode branch from d23e5c0 to 053cfb7 Compare January 14, 2022 14:35
@necatican necatican mentioned this pull request Jan 14, 2022
Closed
7 tasks
@cristicalin
Copy link
Contributor

thanks for doing this @necatican !

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2022
@floryut floryut added kind/network Network section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jan 16, 2022
floryut
floryut approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@necatican Thank you ! 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, necatican

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit caff539 into kubernetes-sigs:master Jan 16, 2022
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
@necatican @eminaktas
@yasinterol @sakuraiyuta
Add identity_allocation_mode support for Cilium (kubernetes-sigs#8430)
cefe7de 
Co-authored-by: Emin Aktaş <eminaktas34@gmail.com>
Co-authored-by: Yasin Taha Erol <yasintahaerol@gmail.com>
Signed-off-by: necatican <necaticanyildirim@gmail.com>

Co-authored-by: Emin Aktaş <eminaktas34@gmail.com>
Co-authored-by: Yasin Taha Erol <yasintahaerol@gmail.com>
@oomichi oomichi mentioned this pull request May 28, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 29, 2023
@necatican @eminaktas
@yasinterol @LuckySB
Add identity_allocation_mode support for Cilium (kubernetes-sigs#8430)
8156699 
Co-authored-by: Emin Aktaş <eminaktas34@gmail.com>
Co-authored-by: Yasin Taha Erol <yasintahaerol@gmail.com>
Signed-off-by: necatican <necaticanyildirim@gmail.com>

Co-authored-by: Emin Aktaş <eminaktas34@gmail.com>
Co-authored-by: Yasin Taha Erol <yasintahaerol@gmail.com>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 20, 2023
@necatican @eminaktas
@yasinterol @LuckySB
Add identity_allocation_mode support for Cilium (kubernetes-sigs#8430)
749cdf6 
Co-authored-by: Emin Aktaş <eminaktas34@gmail.com>
Co-authored-by: Yasin Taha Erol <yasintahaerol@gmail.com>
Signed-off-by: necatican <necaticanyildirim@gmail.com>

Co-authored-by: Emin Aktaş <eminaktas34@gmail.com>
Co-authored-by: Yasin Taha Erol <yasintahaerol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@cristicalin cristicalin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium: Add support for identity-allocation-mode
4 participants
@necatican @k8s-ci-robot @cristicalin @floryut