feat: check & uninstall container engine if needed

[cyril-corbon]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:
we should verify that docker / docker-ce is not installed when we install containerd

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Check & uninstall container engine if needed (when changing container engine defined)

[k8s-ci-robot]

Hi @cyril-corbon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cristicalin]

I'm assuming you are pushing this to address the discussion on #8431 but I don't quite like the approach of removing another container manager in the role that is supposed to cover a different one.

What about the scenario when someone wants to move from docker to cri-o or from cri-o to containerd; in this case we should add a different logic to detect the currently deployed container manager and check it against the desired one then perform a full clean up if necessary. The approach of uninstalling an unrelated container manager would leave unrelated configuration files (think /etc/docker) and state (think /var/lib/docker) behind which could go unnoticed and cause issues later in the cluster lifecycle.

[cyril-corbon]

I thought only docker has containerd as dependency that's why I did that.

Maybe we could add a role to check if a container manager is installed before an installation and removed it ?

This role should remove the package and all his configurations file as you said

[cristicalin]

Personally I would like to see a reset.yml task file added to each container manger role that could be called by a role responsible to detect discrepancies and replace the correct container manager this would ease the maintenance so that roles are specific to each container manager and meta roles don't have technology specific implementations.

[cyril-corbon]

ok I will rename the pr and do that thanks for the feedback 🙇

[cristicalin]

Looks good @cyril-corbon , thanks for doing this!

/ok-to-test
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, cyril-corbon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cristicalin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cristicalin]

/cc @oomichi @floryut

[oomichi]

/lgtm