Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set fallback value of kubelet ip6 (#8858) #8926

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Fix: set fallback value of kubelet ip6 (#8858) #8926

merged 3 commits into from
Jun 6, 2022

Conversation

HoKim98
Copy link
Contributor

@HoKim98 HoKim98 commented Jun 4, 2022 •
edited by oomichi
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This commit will serve the default value of IP6 address when using kubeadm.

Which issue(s) this PR fixes:

Fixes #8858

Special notes for your reviewer:

Use the following configuration values:

etcd_kubeadm_enabled: true
enable_dual_stack_networks: false

Does this PR introduce a user-facing change?:

Set fallback value of kubelet ip6

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 4, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kerryeon / name: Ho Kim (5d0580b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 4, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @kerryeon!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @kerryeon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2022
@k8s-ci-robot k8s-ci-robot requested review from bozzo and oomichi June 4, 2022 10:51
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2022
@HoKim98
Copy link
Contributor Author

HoKim98 commented Jun 4, 2022

/assign @oomichi

HoKim98 and others added 2 commits June 6, 2022 15:37
@HoKim98 @cristicalin
Prune the spurious comma in the end of kubelet_address
1326063 
- Update `roles/kubernetes/node/defaults/main.yml`

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
@HoKim98
Fix: set fallback value of kubelet ip6 (#8858)
c2eac52 
- Apply the lint: 1326063
@cristicalin
Copy link
Contributor

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, kerryeon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@oomichi
Copy link
Contributor

oomichi commented Jun 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 77f436f into kubernetes-sigs:master Jun 6, 2022
@rtsp
Copy link
Member

rtsp commented Jun 7, 2022

Quick note: This fix should backport to release-2.19 too.

chinnonae pushed a commit to chinnonae/kubespray that referenced this pull request Jun 7, 2022
@HoKim98 @cristicalin @chinnonae
Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858) (kubern…
5a89181 
…etes-sigs#8926)

* Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858)

* Prune the spurious comma in the end of kubelet_address

- Update `roles/kubernetes/node/defaults/main.yml`

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858)

- Apply the lint: kubernetes-sigs@1326063

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
@chinnonae chinnonae mentioned this pull request Jun 7, 2022
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jun 8, 2022
@chinnonae @HoKim98 @cristicalin
Fix: set fallback value of kubelet ip6 (#8858) (#8926) (#8942)
cd93d10 
* Fix: set fallback value of kubelet ip6 (#8858)

* Prune the spurious comma in the end of kubelet_address

- Update `roles/kubernetes/node/defaults/main.yml`

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* Fix: set fallback value of kubelet ip6 (#8858)

- Apply the lint: 1326063

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

Co-authored-by: Ho Kim <ho.kim@ulagbulag.io>
Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
@floryut floryut mentioned this pull request Sep 19, 2022
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 1, 2023
@HoKim98 @cristicalin @LuckySB
Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858) (kubern…
0bb9fb3 
…etes-sigs#8926)

* Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858)

* Prune the spurious comma in the end of kubelet_address

- Update `roles/kubernetes/node/defaults/main.yml`

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858)

- Apply the lint: kubernetes-sigs@1326063

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@HoKim98 @cristicalin @LuckySB
Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858) (kubern…
69b16c1 
…etes-sigs#8926)

* Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858)

* Prune the spurious comma in the end of kubelet_address

- Update `roles/kubernetes/node/defaults/main.yml`

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>

* Fix: set fallback value of kubelet ip6 (kubernetes-sigs#8858)

- Apply the lint: kubernetes-sigs@1326063

Co-authored-by: Cristian Calin <6627509+cristicalin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin cristicalin left review comments

@bozzo bozzo Awaiting requested review from bozzo

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed Install at TASK [kubernetes/node : Write kubelet environment config file (kubeadm)] *******
5 participants
@HoKim98 @k8s-ci-robot @cristicalin @oomichi @rtsp