fix a typo in the "matallb_auto_assign" variable name

[orange-llajeanne]

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Fixes a typo in the variable setting the auto-assign param of metallb:
matallb_auto_assign => metallb_auto_assign

Special notes for your reviewer:

This is a breaking change for existing inventories using the matallb_auto_assign variable name. Should kubespray support both names and deprecate the previous one?

Does this PR introduce a user-facing change?:

[Metallb] Renamed `matallb_auto_assign` variable to `metallb_auto_assign` (action required: users disabling 'auto-assign' in metallb must update the variable name)

[k8s-ci-robot]

Hi @orange-llajeanne. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oomichi]

Thanks for fixing the wrong name.
The wrong name is used in long-term.
So it is better to have something to support it for the existing inventory, I feel.

/cc @oomichi

[oomichi]

To support old name in the existing inventory

Suggested change

	metallb_auto_assign: true
	metallb_auto_assign: >-
	{%- if matallb_auto_assign is defined -%}
	{{ matallb_auto_assign }}
	{%- else -%}
	true
	{%- endif -%}

[cristicalin]

I wonder if anyone is actually using the typo'ed variable name. Carrying some compatibility code due to a typo in the past seems like a lot of effort.

[oomichi]

Yeah, this kind of thing is always maintenance burden for developers.
At least, it would be necessary to take 1-2 versions for warning the option is renamed from the original one for users as the deprecation period.
Then we can remove the original one after that.

[floryut]

Well this can be discussed, but a warning in the release note might be enough, or we can add an ansible check and message indeed

[orange-llajeanne]

I updated this PR with the solution proposed by @oomichi , but I can still modify it if this discussion ends up identifying another solution.

[oomichi]

we can add an ansible check and message indeed

@floryut Thanks, that is a good idea for users I think.
@orange-llajeanne Could you update this pull request again based on

kubespray/roles/network_plugin/calico/tasks/check.yml

Lines 2 to 8 in 4726a11

	- name: Stop if legacy encapsulation variables are detected (ipip)
	assert:
	that:
	- ipip is not defined
	msg: "'ipip' configuration variable is deprecated, please configure your inventory with 'calico_ipip_mode' set to 'Always' or 'CrossSubnet' according to your specific needs"
	run_once: True
	delegate_to: "{{ groups['kube_control_plane'][0] }}"

as a reference?

[orange-llajeanne]

I removed the workaround in defaults/main.yml and added a check in metallb tasks, inspired from other checks from the same file

I think this should be ok now

[cristicalin]

Looks good, thanks @orange-llajeanne

/approve
/ok-to-test

[floryut]

/ok-to-test
@orange-llajeanne Fine by me now, thank you 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, orange-llajeanne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oomichi]

Thanks for updating again!

/lgtm