-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allows users to have more control on DNS #9270
Conversation
Signed-off-by: eminaktas <eminaktas34@gmail.com>
Hi @eminaktas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nice work! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eminaktas, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @eminaktas /lgtm |
Signed-off-by: eminaktas <eminaktas34@gmail.com> Signed-off-by: eminaktas <eminaktas34@gmail.com>
Signed-off-by: eminaktas <eminaktas34@gmail.com> Signed-off-by: eminaktas <eminaktas34@gmail.com>
Kubespray should give us more control over DNS. The current behavior limits users to configure DNS settings. The attempts or timeout options are hard coded. No way to fully configure searchdomains.
This PR introduces:
attempts
andtimeout
options.remove_default_searchdomains
will remove default searchdomains.searchdomains
can be fully configurednameserverentries
together. It will be added depending on the condition.What type of PR is this?
/kind feature
Does this PR introduce a user-facing change?:
No, it adds more functionalty to DNS settings.
Signed-off-by: eminaktas eminaktas34@gmail.com