-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preinstall: Add nodelocaldns to supersede_nameserver if enabled #9282
Conversation
When a machine that use dhclient and resolvconf reboots, this will make /etc/resolv.conf remain close to the one before reboot
Hi @azuwis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for this fix @azuwis ! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: azuwis, cristicalin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…rnetes-sigs#9282) When a machine that use dhclient and resolvconf reboots, this will make /etc/resolv.conf remain close to the one before reboot
…rnetes-sigs#9282) When a machine that use dhclient and resolvconf reboots, this will make /etc/resolv.conf remain close to the one before reboot
When a machine that use dhclient and resolvconf reboots, this will make /etc/resolv.conf remain close to the one before reboot
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: