Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ostree variable has been defined #9321

Merged

Conversation

electrocucaracha
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Apparently c942915 relies on the ostree variable definition, which for the runc container engine is not previously defined. This change ensures the variable is defined and fixes the error caused.

Which issue(s) this PR fixes:

Fixes #9161

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2022
@cristicalin
Copy link
Contributor

HI @electrocucaracha , please check and fix the commit message to make the bot happy.

/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 23, 2022
@cristicalin cristicalin added this to the 2.20 milestone Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
The ostree variable is not defined previously raising an error when
the runtime tries to read it.
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 23, 2022
@oomichi
Copy link
Contributor

oomichi commented Sep 24, 2022

Nice work.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2022
@floryut floryut mentioned this pull request Sep 24, 2022
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electrocucaracha Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, electrocucaracha, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cristicalin,floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 782f051 into kubernetes-sigs:master Sep 24, 2022
@electrocucaracha electrocucaracha deleted the fix_ostree-runc branch September 25, 2022 20:43
@Jeroen0494
Copy link
Contributor

@oomichi Could this PR please be backported to Kubespray 2.19 and 2.18? These are currently broken without this code for at least containerd on Ubuntu.

[2022-10-18T12:56:24.245Z] TASK [container-engine/runc : runc | set is_ostree] ****************************
[2022-10-18T12:56:24.245Z] Tuesday 18 October 2022  14:56:24 +0200 (0:00:00.121)       0:15:01.218 ******* 
[2022-10-18T12:56:24.245Z] fatal: [acc-jri-ot-k8sm001]: FAILED! => 
[2022-10-18T12:56:24.245Z]   msg: |-
[2022-10-18T12:56:24.245Z]     The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'stat'
[2022-10-18T12:56:24.245Z]   
[2022-10-18T12:56:24.245Z]     The error appears to be in '/var/lib/jenkins/workspace/k8s/08_docker_migrate_containerd/library/kubespray/roles/container-engine/runc/tasks/main.yml': line 2, column 3, but may
[2022-10-18T12:56:24.245Z]     be elsewhere in the file depending on the exact syntax problem.
[2022-10-18T12:56:24.245Z]   
[2022-10-18T12:56:24.245Z]     The offending line appears to be:
[2022-10-18T12:56:24.245Z]   
[2022-10-18T12:56:24.245Z]     ---
[2022-10-18T12:56:24.245Z]     - name: runc | set is_ostree
[2022-10-18T12:56:24.245Z]       ^ here

enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
The ostree variable is not defined previously raising an error when
the runtime tries to read it.
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
The ostree variable is not defined previously raising an error when
the runtime tries to read it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[container-engine/runc : runc | set is_ostree] failing during cluster upgrade to 1.24.1 on Ubuntu 20.04
6 participants