-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure ostree variable has been defined #9321
Ensure ostree variable has been defined #9321
Conversation
HI @electrocucaracha , please check and fix the commit message to make the bot happy. /approve |
The ostree variable is not defined previously raising an error when the runtime tries to read it.
4e737df
to
b528772
Compare
Nice work. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@electrocucaracha Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, electrocucaracha, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@oomichi Could this PR please be backported to Kubespray 2.19 and 2.18? These are currently broken without this code for at least containerd on Ubuntu.
|
The ostree variable is not defined previously raising an error when the runtime tries to read it.
The ostree variable is not defined previously raising an error when the runtime tries to read it.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Apparently c942915 relies on the
ostree
variable definition, which for the runc container engine is not previously defined. This change ensures the variable is defined and fixes the error caused.Which issue(s) this PR fixes:
Fixes #9161
Special notes for your reviewer:
Does this PR introduce a user-facing change?: