-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download binaries from dl.k8s.io instead of a bucket #251
Conversation
7d2b42e
to
2b531ac
Compare
9196232
to
1fe5a65
Compare
1fe5a65
to
9d7f354
Compare
b7a3dd0
to
7dee8a6
Compare
/assign @michelle192837 @jbpratt This is ready to be merged. Jobs are passing |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbpratt, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
TestPackageVersion string `desc:"The ginkgo tester uses a test package made during the kubernetes build. The tester downloads this test package from one of the release tars published to the Release bucket. Defaults to latest. visit https://kubernetes.io/releases/ to find release names. Example: v1.20.0-alpha.0"` | ||
TestPackageBucket string `desc:"The bucket which release tars will be downloaded from to acquire the test package. Defaults to the main kubernetes project bucket."` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing test failures: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-aws-selinux/1744533959024316416
can we finish migrating all jobs to use the new flag, or add this back as a deprecated flag?
EDIT: updated here: kubernetes/test-infra#31585
`--test-package-bucket` is removed on kubernetes-sigs/kubetest2#251 Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
`--test-package-bucket` is removed on kubernetes-sigs/kubetest2#251 Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
/cc @ameukam @BenTheElder @dims
Fixes: #239
Part of: kubernetes/test-infra#18789 and kubernetes/k8s.io#2396
kops is another large project that fetches from the kubernetes-release/k8s-release-dev buckets but it has a custom implementation at https://github.com/kubernetes/kops/tree/master/tests/e2e/pkg/tester that I'll fix separately.
Lets merge this as soon as code freeze is over and bump the kubekins-e2e image. We should start seeing jobs failing and we can fix them
Improvements: