Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --container-runtime-endpoint for node tester #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add --container-runtime-endpoint for node tester #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/testers/node/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ type Tester struct {
GCPZone string `desc:"GCP Zone to create VMs in."`
SkipRegex string `desc:"Regular expression of jobs to skip."`
FocusRegex string `desc:"Regular expression of jobs to focus on."`
ContainerRuntimeEndpoint string `desc:"remote container endpoint to connect to. Defaults to containerd"`
TestArgs string `desc:"A space-separated list of arguments to pass to node e2e test."`
BoskosAcquireTimeoutSeconds int `desc:"How long (in seconds) to hang on a request to Boskos to acquire a resource before erroring."`
BoskosHeartbeatIntervalSeconds int `desc:"How often (in seconds) to send a heartbeat to Boskos to hold the acquired resource. 0 means no heartbeat."`
Expand Down Expand Up @@ -251,6 +252,7 @@ func (t *Tester) constructArgs() []string {
"CLOUDSDK_CORE_PROJECT=" + t.GCPProject,
// https://github.com/kubernetes/kubernetes/blob/96be00df69390ed41b8ec22facc43bcbb9c88aae/hack/make-rules/test-e2e-node.sh#L113
"ZONE=" + t.GCPZone,
"CONTAINER_RUNTIME_ENDPOINT=" + t.ContainerRuntimeEndpoint,
"TEST_ARGS=" + t.TestArgs,
"NODE_ENV= " + t.NodeEnv,
"DELETE_INSTANCES=" + strconv.FormatBool(t.DeleteInstances),
Expand Down