Skip to content

Commit

Permalink
Fixed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mwielgus committed Apr 30, 2024
1 parent 7aa3b36 commit 3239919
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
13 changes: 9 additions & 4 deletions keps/2076-kueuectl/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ We want to create a command line tool for Kueue that allows to:

* list Kueue's objects with easy to use Kueue-specific filtering,
* create Local and ClusterQueues without writing yamls,
* perform management operations on LQs, CQs and Workloads.
* perform management operations on LQs, CQs, Workloads, ResourceFlavors and other Kueue objects.

## Motivation

Expand All @@ -59,6 +59,8 @@ tedious without writing a custom mini script or complex pipe processing.
* Build it on top of kubectl (as a [kubectl plugin](https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/)) to reuse all of
the authentication/cluster selection methods.

* Expose the plugin in Krew.

### Non-Goals

* Provide any other interface than a command line (no web ui).
Expand All @@ -80,7 +82,8 @@ kueuectl <command> <object> <flags>
```

The commands automatically submit all changes unless `--dry-run` option is given - in that
case the tool will print out yamls without making any changes in the cluster.
case the tool will print out yamls without making any changes in the cluster (we may
submit the yaml with dryrun enabled to the APIServer to get validation error).

### User Stories (Optional)

Expand Down Expand Up @@ -115,7 +118,6 @@ kueuectl create cq|clusterqueue cqname
--namespace-selector=selector # defaults to {} - all namespaces can use the queue
--reclaim-within-cohort=policy # defaults to Never
--preemption-within-cluster-queue = policy # defaults to Never
--preemption-when-borrowing = policy # defaults to Never
–-nominal-quota=rfname1:resource1=value,resource2=value,resource3=value
–-borrowing-limit=rfname1:resource1=value,resource2=value,resource3=value
Expand Down Expand Up @@ -277,7 +279,9 @@ None.
### Stop Workload

Puts the given Workload on hold. The Workload will not be admitted and
if it is already admitted it will be put back to queue just as if it was preempted.
if it is already admitted it will be put back to queue just as if it was preempted
(using `.spec.active` field).

Format:
```
kueuectl stop workload name --namespace=ns
Expand Down Expand Up @@ -340,3 +344,4 @@ KEP: 2023-04-27.

* Use existing kubectl functionality and perform management operations via
API manipulations.
* Don't use kubectl plugins but write CLI from scratch.
2 changes: 1 addition & 1 deletion keps/487-kubectl-plugin/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ title: Kubectl plugin for listing objects
kep-number: 487
authors:
- "@vsoch"
status: provisional
status: replaced # Replaced by KEP #2076
creation-date: 2023-07-11
reviewers:
- "@tenzen-y"
Expand Down

0 comments on commit 3239919

Please sign in to comment.