generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 228
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
RayCluster integration with Kueue (#1520)
* WIP admit RayCluster as kueuable workload updated kubebuilder markers but still workload isnt created updating branch update unit tests working ? changes ray cluster admitted as a workload and running, it has a lot of debug log lines that need to be removed added comma fixed helper method, need to implemente tests changes v1alpha1 to v1 but still workload isnt created pods are not getting suspended :( charts WIP admit RayCluster as kueuable workload updated kubebuilder markers but still workload isnt created updating branch update unit tests working ? changes ray cluster admitted as a workload and running, it has a lot of debug log lines that need to be removed fixed helper method, need to implemente tests changes v1alpha1 to v1 but still workload isnt created updated wrappers not all tests are passing but still working on them debugging podReady test update updated controller and webhook tests, now working updated raycluster webhook test added ray cluster sample yaml updated go modules since this is using kuberay masters version removing diffs from reconciler file removing diffs from reconciler file removing diffs from reconciler file updated role yaml file added TODO comment for autoscaler updated raycluster controller test added scheme for v1 inside register file update rayjob import to reference v1 otherwise tests are not passing in PR changed the order of jobs list updated pod controller api version to be v1 instead of v1alpha1 update go files fixed pull kueue test reverted changes made to rayjob import library version fixed rayjob tests WIP admit RayCluster as kueuable workload updated kubebuilder markers but still workload isnt created updating branch update unit tests working ? changes ray cluster admitted as a workload and running, it has a lot of debug log lines that need to be removed added comma fixed helper method, need to implemente tests changes v1alpha1 to v1 but still workload isnt created pods are not getting suspended :( charts WIP admit RayCluster as kueuable workload updated kubebuilder markers but still workload isnt created updating branch update unit tests working ? changes ray cluster admitted as a workload and running, it has a lot of debug log lines that need to be removed fixed helper method, need to implemente tests changes v1alpha1 to v1 but still workload isnt created updated wrappers not all tests are passing but still working on them debugging podReady test update updated controller and webhook tests, now working updated raycluster webhook test updated go modules since this is using kuberay masters version removing diffs from reconciler file removing diffs from reconciler file removing diffs from reconciler file updated role yaml file added TODO comment for autoscaler updated raycluster controller test added scheme for v1 inside register file update rayjob import to reference v1 otherwise tests are not passing in PR changed the order of jobs list updated pod controller api version to be v1 instead of v1alpha1 update go files fixed pull kueue test reverted changes made to rayjob import library version fixed rayjob tests updated example raycluster nit updated ray cluster controller unit test and wrapper updated tests and charts updated ownerReference for rayJob and rayCluster removed extra configuration for pods and duplicated text generated by script added third argument for reconciler * added logic to ignore rayclusters created by a RayJob reverted git tag change moved the sample yaml file to a different branch addressed comments and used generalised method call in reconciler to check ownership updated new reconciler variable addressed comments nit removed register changes revert changes to go dependencies to test something updated go files nit added schema nit added files generated by make verify update charts test test updated register test fixed test added builder n update fix go modules fixed test nit added case for ray cluster completion nit debugging added test for coverage updated the restore node test nit addressed comments update added scheme for rayv1 in tests nit updated test to inject node selector with flavor defined nit nit
- Loading branch information
Showing
27 changed files
with
2,223 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# permissions for end users to edit jobs. | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: ClusterRole | ||
metadata: | ||
name: '{{ include "kueue.fullname" . }}-raycluster-editor-role' | ||
labels: | ||
rbac.kueue.x-k8s.io/batch-admin: "true" | ||
rbac.kueue.x-k8s.io/batch-user: "true" | ||
rules: | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters | ||
verbs: | ||
- create | ||
- delete | ||
- get | ||
- list | ||
- patch | ||
- update | ||
- watch | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters/status | ||
verbs: | ||
- get |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# permissions for end users to view jobs. | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: ClusterRole | ||
metadata: | ||
name: '{{ include "kueue.fullname" . }}-raycluster-viewer-role' | ||
labels: | ||
rbac.kueue.x-k8s.io/batch-admin: "true" | ||
rules: | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters | ||
verbs: | ||
- get | ||
- list | ||
- watch | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters/status | ||
verbs: | ||
- get |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# permissions for end users to edit jobs. | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: ClusterRole | ||
metadata: | ||
name: raycluster-editor-role | ||
labels: | ||
rbac.kueue.x-k8s.io/batch-admin: "true" | ||
rbac.kueue.x-k8s.io/batch-user: "true" | ||
rules: | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters | ||
verbs: | ||
- create | ||
- delete | ||
- get | ||
- list | ||
- patch | ||
- update | ||
- watch | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters/status | ||
verbs: | ||
- get |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# permissions for end users to view jobs. | ||
apiVersion: rbac.authorization.k8s.io/v1 | ||
kind: ClusterRole | ||
metadata: | ||
name: raycluster-viewer-role | ||
labels: | ||
rbac.kueue.x-k8s.io/batch-admin: "true" | ||
rules: | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters | ||
verbs: | ||
- get | ||
- list | ||
- watch | ||
- apiGroups: | ||
- ray.io | ||
resources: | ||
- rayclusters/status | ||
verbs: | ||
- get |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.