Skip to content

Commit

Permalink
Fix: topologies clusterrole not work
Browse files Browse the repository at this point in the history
Signed-off-by: kerthcet <kerthcet@gmail.com>
  • Loading branch information
kerthcet committed Dec 26, 2024
1 parent 95bc3b2 commit 8e9d775
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
5 changes: 2 additions & 3 deletions charts/kueue/templates/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ rules:
- clusterqueues/finalizers
- localqueues/finalizers
- resourceflavors/finalizers
- topology/finalizers
- topologies/finalizers
- workloads/finalizers
verbs:
- update
Expand All @@ -258,7 +258,6 @@ rules:
- multikueueclusters
- multikueueconfigs
- provisioningrequestconfigs
- topologies
- workloadpriorityclasses
verbs:
- get
Expand All @@ -277,7 +276,7 @@ rules:
- apiGroups:
- kueue.x-k8s.io
resources:
- topology
- topologies
verbs:
- get
- list
Expand Down
5 changes: 2 additions & 3 deletions config/components/rbac/role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ rules:
- clusterqueues/finalizers
- localqueues/finalizers
- resourceflavors/finalizers
- topology/finalizers
- topologies/finalizers
- workloads/finalizers
verbs:
- update
Expand All @@ -257,7 +257,6 @@ rules:
- multikueueclusters
- multikueueconfigs
- provisioningrequestconfigs
- topologies
- workloadpriorityclasses
verbs:
- get
Expand All @@ -276,7 +275,7 @@ rules:
- apiGroups:
- kueue.x-k8s.io
resources:
- topology
- topologies
verbs:
- get
- list
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/tas/topology_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ func (r *topologyReconciler) setupWithManager(mgr ctrl.Manager, cfg *configapi.C
Complete(core.WithLeadingManager(mgr, r, &kueuealpha.Topology{}, cfg))
}

// +kubebuilder:rbac:groups=kueue.x-k8s.io,resources=topology,verbs=get;list;watch;update
// +kubebuilder:rbac:groups=kueue.x-k8s.io,resources=topology/finalizers,verbs=update
// +kubebuilder:rbac:groups=kueue.x-k8s.io,resources=topologies,verbs=get;list;watch;update
// +kubebuilder:rbac:groups=kueue.x-k8s.io,resources=topologies/finalizers,verbs=update

func (r topologyReconciler) Reconcile(ctx context.Context, req reconcile.Request) (reconcile.Result, error) {
topology := &kueuealpha.Topology{}
Expand Down

0 comments on commit 8e9d775

Please sign in to comment.