Address reviews

This commit addresses reviews by adding additional metrics
for local queue.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>

keps/1833-metrics-for-local-queue/README.md

@@ -9,17 +9,16 @@
   - [User Stories (Optional)](#user-stories-optional)
     - [Story 1](#story-1)
     - [Story 2](#story-2)
-  - [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional)
-  - [Risks and Mitigations](#risks-and-mitigations)
+    - [Story 3](#story-3)
 - [Design Details](#design-details)
+  - [API changes:](#api-changes)
+  - [List of metrics for Local Queues:](#list-of-metrics-for-local-queues)
   - [Test Plan](#test-plan)
-      - [Prerequisite testing updates](#prerequisite-testing-updates)
     - [Unit Tests](#unit-tests)
     - [Integration tests](#integration-tests)
   - [Graduation Criteria](#graduation-criteria)
 - [Implementation History](#implementation-history)
 - [Drawbacks](#drawbacks)
-- [Alternatives](#alternatives)
 <!-- /toc -->
 
 ## Summary
@@ -124,12 +123,15 @@ knobs will be available:
 
 In the first iteration, following are the list of metrics that would contain information on Local Queue statuses:
 
-| Metrics Name                   | Prometheus Type | Description                                                 | 
-|--------------------------------|-----------------|-------------------------------------------------------------|
-| local_queue_pending_workloads  | Gauge           | The number of pending workloads                             |
-| local_queue_reserved_workloads | Counter         | Total number of workloads in the LocalQueue reserving quota |
-| local_queue_admitted_workloads | Counter         | Total number of admitted workloads                          |
-| local_queue_resource_usage     | Gauge           | Total quantity of used quota per resource for a Local Queue |
+| Metrics Name                             | Prometheus Type | Description                                                                                         | 
+|------------------------------------------|-----------------|-----------------------------------------------------------------------------------------------------|
+| local_queue_pending_workloads            | Gauge           | The number of pending workloads                                                                     |
+| local_queue_reserved_workloads_total     | Counter         | Total number of workloads in the LocalQueue reserving quota                                         |
+| local_queue_admitted_workloads_total     | Counter         | Total number of admitted workloads                                                                  |
+| local_queue_resource_usage               | Gauge           | Total quantity of used quota per resource for a Local Queue                                         |
+| local_queue_evicted_workloads_total      | Counter         | The total number of evicted workloads in Local Queue.                                               |
+| local_queue_admission_wait_time_seconds  | Histogram       | The time from when a workload got the quota reservation until admission in local queue.             |
+| local_queue_reserved_wait_time_seconds   | Histogram       | The time between a workload was created or re-queued until it got quota reservation in local queue. |
 
 Each of these metrics will be augmented with relevant Prometheus labels, indicating the local queue name, namespace, 
 and any other unique identifiers as required during implementation.