Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dep] Updated k8s.io/autoscaler/cluster-autoscaler version to a stable one. #1194

Closed
trasc opened this issue Oct 11, 2023 · 8 comments
Closed
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@trasc
Copy link
Contributor

trasc commented Oct 11, 2023

What would you like to be cleaned:

Use a released version of k8s.io/autoscaler/cluster-autoscaler containing kubernetes/autoscaler@5155725

Why is this needed:

Have clean dependencies.

@trasc trasc added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 11, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@trasc Since released the new cluster-autoscaler with PriviosningRequest API, we can do this, right?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2024
@trasc
Copy link
Contributor Author

trasc commented Feb 12, 2024

@tenzen-y Indeed the the code we need is now part of a github release 1.29.0 but unfortunately the release is tagged with cluster-autoscaler-1.29.0 instead of cluster-autoscaler/v1.29.0 and it cannot be referenced from go.mod.

@tenzen-y
Copy link
Member

@tenzen-y Indeed the the code we need is now part of a github release 1.29.0 but unfortunately the release is tagged with cluster-autoscaler-1.29.0 instead of cluster-autoscaler/v1.29.0 and it cannot be referenced from go.mod.

@trasc Yea, that makes sense. Indeed, I'm working on new tag format k8s.io/autoscaler/cluster-autoscaler/apis in kubernetes/autoscaler#6315 (comment).

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2024
@tenzen-y
Copy link
Member

This is replaced with #1896
/close

@k8s-ci-robot
Copy link
Contributor

@tenzen-y: Closing this issue.

In response to this:

This is replaced with #1896
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

4 participants