Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hugo template to highlight minimum supported version #2325

Closed
1 of 3 tasks
alculquicondor opened this issue May 29, 2024 · 8 comments · Fixed by #2342
Closed
1 of 3 tasks

Add a hugo template to highlight minimum supported version #2325

alculquicondor opened this issue May 29, 2024 · 8 comments · Fixed by #2342
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@alculquicondor
Copy link
Contributor

alculquicondor commented May 29, 2024

What would you like to be added:

Some reusable block that looks similar to the following:

image

And then use that for every time we mention that a feature is only available in a certain version.

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label May 29, 2024
@alculquicondor
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@alculquicondor:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 29, 2024
@ivange94
Copy link
Contributor

Hi @alculquicondor, I would like to work on this. I'm new to the project and will appreciate some guidance on how to go about this.

@alculquicondor
Copy link
Contributor Author

You can probably look at this PR for inspiration #2006

To see your work locally, you can run make site-server

@ivange94
Copy link
Contributor

/assign

@ivange94
Copy link
Contributor

ivange94 commented Jun 3, 2024

@alculquicondor is there somewhere that we need to use this block right now? To test this I just added it to a random page but didn't commit this change. This is how it looks like.
Screenshot 2024-06-01 at 6 05 09 PM

It also looks like I didn't configure my git properly so it didn't use my actual email address and the bots say I didn't sign the license agreement. Would it be okay to edit that commit and force push to my branch or should I close the current PR and create a new one?

@tenzen-y
Copy link
Member

tenzen-y commented Jun 3, 2024

It also looks like I didn't configure my git properly so it didn't use my actual email address and the bots say I didn't sign the license agreement. Would it be okay to edit that commit and force push to my branch or should I close the current PR and create a new one?

@ivange94 We're ok with either way.

@tenzen-y
Copy link
Member

tenzen-y commented Jun 3, 2024

@alculquicondor is there somewhere that we need to use this block right now? To test this I just added it to a random page but didn't commit this change. This is how it looks like.

We aim to replace the warnings/notes like the ones below.

https://kueue.sigs.k8s.io/docs/tasks/manage/setup_sequential_admission/#requeuing-strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants