-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish between Preemption due to reclamation and fair sharing #2404
Comments
/assign |
kueue/pkg/scheduler/scheduler.go Lines 247 to 251 in 6ecaa87
If Assigment is borrowing then the reason should be InCohortFairSharing? Or should the decision be based on kueue/pkg/scheduler/preemption/preemption.go Lines 49 to 59 in 45eee46
|
I think the decision is based entirely on the preemptor. If the preemptor fits in the nominal quota of its ClusterQueue, then it's preempting others that are borrowing its quota. Note that whether fair sharing is enabled is global. /assign @vladikkuzn |
cc @gabesaba |
Also, if the preemptor and preemptee are in the same cluster queue we can say it's a simple priority based eviction (no quota is reclaimed from a borrower) |
What would you like to be added:
An additional reason in the Preemption condition to indicate that the preemption was due to fair sharing and not regular reclamation.
The current reason for reclamation or fair sharing is
InCohort
We could have:
InCohortReclamation
andInCohortFairSharing
.Why is this needed:
For better visibility
Completion requirements:
This enhancement requires the following artifacts:
The artifacts should be linked in subsequent comments.
The text was updated successfully, but these errors were encountered: