-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detailed preemption reason bug #2629
Fix detailed preemption reason bug #2629
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign |
/cc @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update TestPreemption
so that we check also for the reason and not just the set of preempted workloads?
Otherwise we might be missing other bugs.
Good point, I only updated TestFairPreemptions in my last PR, will do |
b805aa9
to
b0110e5
Compare
* If allowBorrowingBelowPriority is nil, then the reason should stay as InCohortReclamationReason * Add reason assertions to TestPreemption
b0110e5
to
1dcfd4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 672ca9ab430b82278d9645290145bf1ddc681598
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, vladikkuzn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
Because the previous PR was not part of a release yet. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If allowBorrowingBelowPriority is nil, then the reason should stay as InCohortReclamationReason
Which issue(s) this PR fixes:
Fixes #2404
Special notes for your reviewer:
Does this PR introduce a user-facing change?