Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand testgrids per test #402

Closed
alculquicondor opened this issue Sep 19, 2022 · 9 comments · Fixed by #423
Closed

Expand testgrids per test #402

alculquicondor opened this issue Sep 19, 2022 · 9 comments · Fixed by #423
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be cleaned:

Currently, the testgrids for unit and integration tests only mark whether the entire suite passed or not.

It would useful to have rows for each test.

Why is this needed:

To be able to track flakiness of specific tests.

Notes:

I don't know how to achieve this, but here is where the presubmits are defined:

https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kueue/kueue-presubmits.yaml

@alculquicondor alculquicondor added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 19, 2022
@alculquicondor
Copy link
Contributor Author

/help

@k8s-ci-robot
Copy link
Contributor

@alculquicondor:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 19, 2022
@alculquicondor
Copy link
Contributor Author

@alculquicondor
Copy link
Contributor Author

Or producing a junit XML report 🤷

@BenTheElder
Copy link
Member

@kannon92
Copy link
Contributor

So if I'm reading this right, we need to generate junit-xml reports for our tests. How exactly do these artifacts get uploaded to testgrid?

@alculquicondor Since I will be opening a PR to testgrid once I get #421 merged, I'll experiment with junit for that and then apply these findings to the other tests?

@BenTheElder
Copy link
Member

So if I'm reading this right, we need to generate junit-xml reports for our tests. How exactly do these artifacts get uploaded to testgrid?

Testgrid reads junit.xml artifacts from what the CI uploads ($ARTIFACTS directory).

@kannon92
Copy link
Contributor

/assign @kannon92

@kannon92
Copy link
Contributor

Hello @BenTheElder, thank you for your help. I believe I figured out how to add testgrid per test.

#423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants