-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an event and update workload status when failing to schedule a workload #91
Comments
Let's block this on #87 |
Actually, it shouldn't conflict much. Related: #102 |
/help |
@ahg-g: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/good-first-issue |
@ahg-g: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ahg-g, I am interested on working on this issue if it is not being worked upon at the moment. Please let me know if I can assign this issue to myself. |
if it's not assigned and it's marked as "good first issue" it's free to take :) |
Thanks @alculquicondor.. |
/assign |
This is great, thanks @uroy-personal , please let us know if you need help; are you planning on working on it soon? |
Yes of course. I will start later today. Will keep you posted on progress and will reach out to you on slack if I get any queries. Thanks for providing me the opportunity to be part of this project. |
@ArangoGutierrez for this one, I guess we could simply create an event in the same place where you are updating the conditions, right? |
yup, the wrapper func looks like the right place |
/assign |
@ArangoGutierrez I assume you will be working on this, correct? |
Yes, i started working on this late Friday, planning on opening PR tomorrow Monday. |
Probably for the workloads that wasn't returned in this loop:
kueue/pkg/scheduler/scheduler.go
Line 142 in 9912f26
The text was updated successfully, but these errors were encountered: