Extend make verify to fully check charts/kueue/templates

[trasc]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Extend make verify to fully check charts/kueue/templates

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	ad5e282
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/64dca6f8128e890008c83932

[trasc]

/cc @tenzen-y
/cc @alculquicondor

[tenzen-y]

Suggested change

	git --no-pager diff --exit-code config/components apis charts/kueue/templates client-go
	git --no-pager diff --exit-code config/components apis charts/kueue/templates/crd charts/kueue/templates/rbac client-go

Should we verify only crd and rbac since update-helm.sh syncs only those folders?

[trasc]

In my opinion no. The current way it's easier to follow, and if in the future other templates are auto updated are automatically updated we will not miss to update the check.

[tenzen-y]

I don't have strong objections. I was just concerned that it would get the error in this script even when we changed the helm templates, which requires manual changes.

[tenzen-y]

if in the future other templates are auto updated are automatically updated we will not miss to update the check.

Anyway, It makes sense on this.

[tenzen-y]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment