UT: workload marked as finished when job completes

[alculquicondor]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add unit test for marking workloads as finished when a job completes.

The mock client simulates SSA using strategic merge, which only looks at the patchStrategy and not mapType.

Then, this PR also introduces the patchStrategy:"merge". This also allows external controllers or CLIs to do client-side apply, merging two lists of conditions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add mergeStrategy:merge to all conditions of API objects

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	55da13a
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/64f230d3935e8e00086c8e15

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

/assign @tenzen-y

[tenzen-y]

Why do we need these markers to add unit tests?

[alculquicondor]

Because the mock client uses StrategicMerge to implement SSA, which only looks at the patchStrategy, not the mapType.

There is an open issue to fix the mock client to be more like the real apiserver kubernetes/kubernetes#115598

However, in the meantime, @apelisse suggested that I add a patchStrategy. This also gives the ability for external controllers to use client-side apply and easily merge two lists of conditions.

[tenzen-y]

Thanks for clarifying. I'm a bit confused since IIUC, the StrategicMergePatch can be used only for Client Side Apply (CSA), right?

However, by this PR, the controller uses SSA with StarategicMergePatch to update workload condition:

kueue/pkg/workload/workload.go

Line 263 in 483ef8a

return c.Status().Patch(ctx, newWl, client.Apply, client.FieldOwner(managerPrefix+"-"+condition.Type))

Which apply strategy will the controller use to update workload conditions? CSA vs SSA
Should we use a customized fake patch client to avoid performance issues instead of adding these markers if CSA is used?

kubernetes-sigs/controller-runtime#2341 (comment)

[alculquicondor]

Apply means that it will use SSA.
It's only the fake client that implements SSA as it was CSA.

This is enough for our purposes for now.

[tenzen-y]

Ah, I see. So, CSA would be used only when unit tests.
Thanks again.

[tenzen-y]

UT looks good to me.

[tenzen-y]

/lgtm