Bump K8s dependencies to v1.28 #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
needs-rebase
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
bump-k8s-dependencies-to-128
branch
from
929df0e to
15e7d1b
Compare
k8s-ci-robot
removed
the
needs-rebase
tenzen-y
commented
Sep 19, 2023
| "all" \ | ||
| applyconfiguration,client,lister,informer \ |
There was a problem hiding this comment.
We must set proper commands since the behavior of all was changed.
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
commented
Sep 19, 2023
| @@ -24,8 +24,9 @@ CODEGEN_PKG=$($GO_CMD list -m -f "{{.Dir}}" k8s.io/code-generator) | |||
|
|
|||
| cd $(dirname ${BASH_SOURCE[0]})/.. | |||
|
|
|||
| chmod +x "${CODEGEN_PKG}/generate-internal-groups.sh" | |||
There was a problem hiding this comment.
tenzen-y
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
tenzen-y
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
bump-k8s-dependencies-to-128
branch
from
a395485 to
89329c3
Compare
This was referenced Sep 19, 2023
|
/assign @mimowo |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 44eacb58dc8c25dc90699026068f6ce5a6fa223f
|
trasc
added a commit
to epam/kubernetes-kueue
that referenced
this pull request
Sep 25, 2023
Fix out of GOPATH client-go generation after `Bump K8s dependencies to v1.28 kubernetes-sigs#1133`
trasc
added a commit
to epam/kubernetes-kueue
that referenced
this pull request
Sep 25, 2023
Fix out of GOPATH client-go generation after `Bump K8s dependencies to v1.28 kubernetes-sigs#1133`
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Fix out of GOPATH client-go generation after `Bump K8s dependencies to v1.28 #1133`
PBundyra
pushed a commit
to PBundyra/kueue
that referenced
this pull request
Sep 25, 2023
Fix out of GOPATH client-go generation after `Bump K8s dependencies to v1.28 kubernetes-sigs#1133`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
I upgraded the following K8s dependencies:
k8s.io/.*controller-runtimecert-controllerWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?