Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decrease reclaimable pods to 0 for suspended job #1277

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Allow decrease reclaimable pods to 0 for suspended job #1277

merged 1 commit into from
Oct 28, 2023

Conversation

yaroslava-serdiuk
Copy link
Contributor

What type of PR is this?

/kind feature

Which issue(s) this PR fixes:

Fixes #1215

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow decrease reclaimable pods to 0 for suspended job

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 5ae1988
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/653cb9bef1005f0008a89005
😎 Deploy Preview https://deploy-preview-1277--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yaroslava-serdiuk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2023
@yaroslava-serdiuk
Copy link
Contributor Author

/assign @mimowo

mimowo
mimowo reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @alculquicondor

pkg/webhooks/workload_webhook.go Outdated
@@ -388,14 +388,17 @@ func validateReclaimablePodsUpdate(newObj, oldObj *kueue.Workload, basePath *fie
for i := range newObj.Status.ReclaimablePods {
newCount := &newObj.Status.ReclaimablePods[i]
newNames.Insert(newCount.Name)
if !workload.HasQuotaReservation(newObj) && newCount.Count == 0{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if !workload.HasQuotaReservation(newObj) && newCount.Count == 0{
if !workload.HasQuotaReservation(newObj) && newCount.Count == 0 {

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa8730c34f45c3f3fc9ab0650ac940fa5454f915

@alculquicondor
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2023
alculquicondor
alculquicondor reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2023
tenzen-y
tenzen-y reviewed Oct 28, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 75b2c10c5e951b536292c083aaa5d03ee9b393d2

@k8s-ci-robot k8s-ci-robot merged commit 1684bf8 into kubernetes-sigs:main Oct 28, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Oct 28, 2023
@alculquicondor
Copy link
Contributor

/kind api-change

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 13, 2024
@tenzen-y
Copy link
Member

/kind api-change

@alculquicondor As I can see, we change only webhooks. Is changing webhooks included in kind/api-change?

@alculquicondor
Copy link
Contributor

Yeah, a change in the validation is an API change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

When a job resets reclaimable pods when evicted, it gets stuck due to Workload validation
5 participants
@yaroslava-serdiuk @k8s-ci-robot @alculquicondor @tenzen-y @mimowo