Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client-go libraries bug #1294

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

tenzen-y
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

The client-go libraries for the Cluster scope, such as ClusterQueue, don't work fine since the libraries are generated for the Namespaced scope resources.

So, I fixed markers for the code-generator so that we can generate proper libraries.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

When we use the current client-go libraries, we will face the following errors:

an empty namespace may not be set when a resource name is provided

Does this PR introduce a user-facing change?

Fix client-go libraries bug that can not operate clusterScoped resources like ClusterQueue and ResourceFlavor.

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 689deb5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/653f83571695530008d430ff

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2023
@tenzen-y
Copy link
Member Author

/assign @trasc

@tenzen-y
Copy link
Member Author

/cherry-pick release-0.5

@k8s-infra-cherrypick-robot

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d08cdd89ee0de17b514b18953a70f6a3fdfb95c7

@k8s-ci-robot k8s-ci-robot merged commit cf0cec3 into kubernetes-sigs:main Oct 30, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Oct 30, 2023
@k8s-infra-cherrypick-robot

@tenzen-y: new pull request created: #1297

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants