A mechanism to stop a ClusterQueue #1299

trasc · 2023-10-30T15:26:30Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added a setting in a ClusterQueue stopPolicy, for an administrator to pause new admissions and/or stop all running jobs.

Why is this needed:

Which issue(s) this PR fixes:

Fixes #1284

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A `stopPolicy` field in the ClusterQueue allows to hold or drain a ClusterQueue

k8s-ci-robot · 2023-10-30T15:26:33Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

netlify · 2023-10-30T15:26:37Z

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	`1d9d21e`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/657012d21ec47e00081a4a7d
😎 Deploy Preview	https://deploy-preview-1299--kubernetes-sigs-kueue.netlify.app/docs/concepts/cluster_queue
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

trasc · 2023-11-06T08:52:59Z

/cc @yaroslava-serdiuk

k8s-ci-robot · 2023-11-06T08:53:02Z

@trasc: GitHub didn't allow me to request PR reviews from the following users: yaroslava-serdiuk.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yaroslava-serdiuk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stuton · 2023-11-23T20:20:39Z

/retitle A mechanism to stop a ClusterQueue

stuton · 2023-11-23T20:23:43Z

/release-note-edit Added a mechanism to stop a ClusterQueue.

alculquicondor · 2023-11-24T17:00:32Z

Please update based on the KEP

alculquicondor · 2023-11-28T15:09:23Z

/assign @yaroslava-serdiuk
for reviews

yaroslava-serdiuk · 2023-11-29T15:08:33Z

I'll review when tests are fixed

yaroslava-serdiuk

Thanks for the change! Left few comments

pkg/cache/clusterqueue.go

pkg/queue/manager_test.go

pkg/controller/core/workload_controller.go

site/content/en/docs/concepts/cluster_queue.md

pkg/queue/manager.go

alculquicondor

/approve
I'll leave LGTM to @yaroslava-serdiuk

apis/kueue/v1beta1/clusterqueue_types.go

apis/kueue/v1beta1/workload_types.go

pkg/cache/clusterqueue.go

pkg/util/testing/wrappers.go

tenzen-y

Totaly LGTM
I left comments for some nits.

apis/kueue/v1beta1/workload_types.go

site/content/en/docs/concepts/cluster_queue.md

pkg/queue/manager_test.go

test/integration/scheduler/scheduler_test.go

yaroslava-serdiuk

/lgtm

pkg/queue/manager.go

k8s-ci-robot · 2023-12-06T10:09:42Z

LGTM label has been added.

Git tree hash: d26a520d427dc784205402ed64bf5ec15124c947

k8s-ci-robot · 2023-12-06T10:09:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yaroslava-serdiuk · 2023-12-06T10:11:51Z

/hold
maybe squash commits?

yaroslava-serdiuk · 2023-12-06T10:14:18Z

/unhold too late :)

JayFrank · 2024-01-11T02:55:13Z

Could the title be misleading? Maybe "A mechanism to pause or stop a ClusterQueue" would be better?

alculquicondor · 2024-01-11T14:02:40Z

/release-note-edit

A `stopPolicy` field in the ClusterQueue allows to hold or drain a ClusterQueue

alculquicondor · 2024-01-23T19:10:10Z

/kind feature

tenzen-y · 2024-02-12T20:51:56Z

/kind api-change

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 30, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2023

k8s-ci-robot requested review from ahg-g and ArangoGutierrez October 30, 2023 15:26

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2023

trasc mentioned this pull request Oct 30, 2023

A mechanism to stop a ClusterQueue #1284

Closed

3 tasks

stuton force-pushed the stop-cq branch from 2455c1d to a997184 Compare November 23, 2023 12:04

k8s-ci-robot changed the title ~~WIP Stop cq~~ A mechanism to stop a ClusterQueue Nov 23, 2023

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2023

trasc marked this pull request as ready for review November 24, 2023 11:27

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023

k8s-ci-robot requested review from denkensk and mimowo November 24, 2023 11:27

stuton force-pushed the stop-cq branch 2 times, most recently from dccdbf6 to 282edf4 Compare November 24, 2023 13:14

k8s-ci-robot assigned yaroslava-serdiuk Nov 28, 2023

stuton force-pushed the stop-cq branch 3 times, most recently from 5425b8d to b9f7d02 Compare November 30, 2023 15:48

Anton Stuchinskii added 3 commits December 1, 2023 16:51

tests for stopping cluster queue

00c77c3

stopPolicy default value

cf7cfb2

update tests

923ab02

stuton force-pushed the stop-cq branch from 5f96392 to 923ab02 Compare December 1, 2023 15:51

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2023

yaroslava-serdiuk reviewed Dec 4, 2023

View reviewed changes

pkg/cache/clusterqueue.go Outdated Show resolved Hide resolved

pkg/queue/manager_test.go Outdated Show resolved Hide resolved

pkg/controller/core/workload_controller.go Outdated Show resolved Hide resolved

pkg/controller/core/workload_controller.go Outdated Show resolved Hide resolved

trasc added 2 commits December 5, 2023 13:39

Review Remarks, Reworks and Documentation.

5a46f59

Drop multiple import of api/meta

1bb608e

yaroslava-serdiuk reviewed Dec 5, 2023

View reviewed changes

site/content/en/docs/concepts/cluster_queue.md Outdated Show resolved Hide resolved

pkg/queue/manager.go Show resolved Hide resolved

alculquicondor reviewed Dec 5, 2023

View reviewed changes

apis/kueue/v1beta1/clusterqueue_types.go Outdated Show resolved Hide resolved

apis/kueue/v1beta1/workload_types.go Outdated Show resolved Hide resolved

pkg/cache/clusterqueue.go Outdated Show resolved Hide resolved

pkg/util/testing/wrappers.go Outdated Show resolved Hide resolved

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023

Review Remarks

2ca88ee

tenzen-y reviewed Dec 6, 2023

View reviewed changes

Review Remarks

1d9d21e

yaroslava-serdiuk approved these changes Dec 6, 2023

View reviewed changes

pkg/queue/manager.go Show resolved Hide resolved

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023

k8s-ci-robot merged commit 4d7f990 into kubernetes-sigs:main Dec 6, 2023
14 checks passed

k8s-ci-robot added this to the v0.6 milestone Dec 6, 2023

trasc deleted the stop-cq branch December 14, 2023 11:17

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2024

k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A mechanism to stop a ClusterQueue #1299

A mechanism to stop a ClusterQueue #1299

trasc commented Oct 30, 2023 •

edited by k8s-ci-robot

Loading

k8s-ci-robot commented Oct 30, 2023

netlify bot commented Oct 30, 2023 •

edited

Loading

trasc commented Nov 6, 2023

k8s-ci-robot commented Nov 6, 2023

stuton commented Nov 23, 2023

stuton commented Nov 23, 2023 •

edited

Loading

alculquicondor commented Nov 24, 2023

alculquicondor commented Nov 28, 2023

yaroslava-serdiuk commented Nov 29, 2023

yaroslava-serdiuk left a comment

alculquicondor left a comment

tenzen-y left a comment

yaroslava-serdiuk left a comment

k8s-ci-robot commented Dec 6, 2023

k8s-ci-robot commented Dec 6, 2023

yaroslava-serdiuk commented Dec 6, 2023

yaroslava-serdiuk commented Dec 6, 2023

JayFrank commented Jan 11, 2024

alculquicondor commented Jan 11, 2024

alculquicondor commented Jan 23, 2024

tenzen-y commented Feb 12, 2024

A mechanism to stop a ClusterQueue #1299

A mechanism to stop a ClusterQueue #1299

Conversation

trasc commented Oct 30, 2023 • edited by k8s-ci-robot Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-ci-robot commented Oct 30, 2023

netlify bot commented Oct 30, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

trasc commented Nov 6, 2023

k8s-ci-robot commented Nov 6, 2023

stuton commented Nov 23, 2023

stuton commented Nov 23, 2023 • edited Loading

alculquicondor commented Nov 24, 2023

alculquicondor commented Nov 28, 2023

yaroslava-serdiuk commented Nov 29, 2023

yaroslava-serdiuk left a comment

Choose a reason for hiding this comment

alculquicondor left a comment

Choose a reason for hiding this comment

tenzen-y left a comment

Choose a reason for hiding this comment

yaroslava-serdiuk left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 6, 2023

k8s-ci-robot commented Dec 6, 2023

yaroslava-serdiuk commented Dec 6, 2023

yaroslava-serdiuk commented Dec 6, 2023

JayFrank commented Jan 11, 2024

alculquicondor commented Jan 11, 2024

alculquicondor commented Jan 23, 2024

tenzen-y commented Feb 12, 2024

trasc commented Oct 30, 2023 •

edited by k8s-ci-robot

Loading

netlify bot commented Oct 30, 2023 •

edited

Loading

stuton commented Nov 23, 2023 •

edited

Loading