Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When preempting in a flavor, retry all flavors in the next iteration #1332

Merged
merged 1 commit into from
Nov 15, 2023
Merged

When preempting in a flavor, retry all flavors in the next iteration #1332

merged 1 commit into from
Nov 15, 2023

Conversation

alculquicondor
Copy link
Contributor

@alculquicondor alculquicondor commented Nov 14, 2023 •
edited by k8s-ci-robot

What type of PR is this?

/kind bug

What this PR does / why we need it:

Wipe the last assignment information when issuing preemptions, as the scheduler should retry all flavors in the next admission attempt.

Also ensure that the integration test checks for the admission flavor, not just that a workload was preempted.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed fungibility policy `whenCanPreempt: Preempt`. The admission should happen in the flavor for which preemptions were issued.

@alculquicondor
When preempting in a flavor, retry all flavors in the next iteration
ea79af7 
Change-Id: I9b58ebc3e5f7997a8f5ae8c2003f6a869c42bb98
@alculquicondor
Copy link
Contributor Author

cc @KunWuLuan

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit ea79af7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6553cc39a90565000870e3cb
😎 Deploy Preview https://deploy-preview-1332--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2023
tenzen-y
tenzen-y reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7154dda7e74201b8b7697c0456e60aadb6b9d598

@tenzen-y
Copy link
Member

/cherry-pick release-0.5

@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit c2f21f4 into kubernetes-sigs:main Nov 15, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Nov 15, 2023
@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: new pull request created: #1333

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 15, 2023
Merged
@tenzen-y
Copy link
Member

/release-note-edit

Fixed fungibility policy `whenCanPreempt: Preempt`. The admission should happen in the flavor for which preemptions were issued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alculquicondor @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot