-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebuilt workload suport #1358
Prebuilt workload suport #1358
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @mwielgus |
54429e7
to
0d47e51
Compare
0d47e51
to
ddc2c4c
Compare
ddc2c4c
to
bbfc832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bbfc832
to
5683478
Compare
/unhold |
/lgtm |
LGTM label has been added. Git tree hash: 4424a785f8e5370c93a75082120e0b1b879438c6
|
ACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if I want to delete a Workload before a Job had a chance to use it?
Would the Workload be finalized? Or is that something that will be solved with #1454 ?
e42599b
to
6bb596b
Compare
This should be manage by the mechanism that creates the wl. (overall having the wl finalizer set only for the duration ta ability to restore the podset info wold have made this easier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 151eb975a07171c0cdd6c9ae3750051015550022
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add the possibility for a job to take the ownership of an existing workload instead of creating it's own.
The target workload is specified in the
kueue.x-k8s.io/prebuilt-workload-name
label of the job.If the workload is not present , the job will stay suspended.
If the workload exists but is not equivalent with the job, it will be marked as
Finished
with failure and the job will remain suspended.Which issue(s) this PR fixes:
Relates to #693
Special notes for your reviewer:
For
batch/job
, the pod-template gets a set of lables derived from the job name and object UID, these labels should not be modified byRunWithPodSetsInfo
orRestorePodSetsInfo
. This is covered in the current PR.Other job types might have different special behavior to take into account, that is why we limit the usage of the feature to
batch/job
for now. We should extend the list of supported job types as needed during the job type integration with multikueue.Does this PR introduce a user-facing change?