Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature gate for priorities sorting in a cohort #1406

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add feature gate for priorities sorting in a cohort #1406

merged 1 commit into from
Dec 12, 2023

Conversation

yaroslava-serdiuk
Copy link
Contributor

@yaroslava-serdiuk yaroslava-serdiuk commented Dec 5, 2023 •
edited by k8s-ci-robot

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow to disable workload priority sorting in a cohort

Which issue(s) this PR fixes:

Related to #1283

Does this PR introduce a user-facing change?

The priority sorting within the cohort could be disabled by setting the feature gate PrioritySortingWithinCohort to false

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit e8a5694
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/657839b88e9bae0008c9fc19

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2023
@yaroslava-serdiuk yaroslava-serdiuk mentioned this pull request Dec 5, 2023
Closed
3 tasks
@alculquicondor
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@tenzen-y
Copy link
Member

lgtm

tenzen-y
tenzen-y reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 66d454a04b548cf35c1ea6ec0b8237e9460e8cfd

@k8s-ci-robot k8s-ci-robot merged commit 4cff47b into kubernetes-sigs:main Dec 12, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Dec 12, 2023
vicentefb pushed a commit to vicentefb/kueue that referenced this pull request Dec 14, 2023
@yaroslava-serdiuk @vicentefb
Add feature gate for priorities sorting in a cohort (kubernetes-sigs#…
2017ddb 
…1406)
@alculquicondor alculquicondor mentioned this pull request Dec 14, 2023
Closed
@alculquicondor
Copy link
Contributor

/release-note-edit

The priority sorting within the cohort could be disabled by setting the feature gate PrioritySortingWithinCohort to false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yaroslava-serdiuk @alculquicondor @k8s-ci-robot @tenzen-y