Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record events when QuotaReservation and Admition take place. #1436

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Dec 11, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Record different events when QuotaReservation and Admition take place.

Which issue(s) this PR fixes:

Fixes #1392

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added event for QuotaReserved and fixed event for Admitted to trigger when admission checks complete

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 11, 2023
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 30fa933
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/657b15e69ffee30009485801

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2023
@trasc
Copy link
Contributor Author

trasc commented Dec 11, 2023

/hold For #1428 to merge, it uses that same test event recorder.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@trasc
Copy link
Contributor Author

trasc commented Dec 11, 2023

/retest

@trasc
Copy link
Contributor Author

trasc commented Dec 13, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@trasc
Copy link
Contributor Author

trasc commented Dec 13, 2023

/cc @alculquicondor

Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a couple of nits

pkg/controller/core/workload_controller.go Outdated Show resolved Hide resolved
pkg/controller/core/workload_controller_test.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/controller/core/workload_controller.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler_test.go Show resolved Hide resolved
@mimowo
Copy link
Contributor

mimowo commented Dec 14, 2023

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14df760793c2eae53a56cd575d8dbf937ad066d1

@alculquicondor
Copy link
Contributor

/kind bug
/remove-kind feature
/cherry-pick release-0.5
Because the existing events say "admitted", when it actually refers to quota reservation.

/release-note-edit

Added event for QuotaReserved and fixed event for Admitted to trigger when admission checks complete

@k8s-infra-cherrypick-robot

@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you.

In response to this:

/kind bug
/remove-kind feature
/cherry-pick release-0.5
Because the existing events say "admitted", when it actually refers to quota reservation.

/release-note-edit

Added event for QuotaReserved and fixed event for Admitted to trigger when admission checks complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 14, 2023
@alculquicondor
Copy link
Contributor

/retest
(due to flaky test)

@k8s-ci-robot k8s-ci-robot merged commit fd9d32e into kubernetes-sigs:main Dec 14, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.6 milestone Dec 14, 2023
@k8s-infra-cherrypick-robot

@alculquicondor: #1436 failed to apply on top of branch "release-0.5":

Applying: Use different events for QuotaReservation and Admission
Using index info to reconstruct a base tree...
M	pkg/constants/constants.go
M	pkg/controller/core/workload_controller.go
M	pkg/scheduler/scheduler.go
M	pkg/scheduler/scheduler_test.go
M	pkg/util/testing/client.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/util/testing/client.go
CONFLICT (content): Merge conflict in pkg/util/testing/client.go
Auto-merging pkg/scheduler/scheduler_test.go
Auto-merging pkg/scheduler/scheduler.go
Auto-merging pkg/controller/core/workload_controller.go
Auto-merging pkg/constants/constants.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use different events for QuotaReservation and Admission
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/kind bug
/remove-kind feature
/cherry-pick release-0.5
Because the existing events say "admitted", when it actually refers to quota reservation.

/release-note-edit

Added event for QuotaReserved and fixed event for Admitted to trigger when admission checks complete

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Contributor

/reopen
@trasc please prepare a cherry-pick for release-0.5

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

In response to this:

/reopen
@trasc please prepare a cherry-pick for release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trasc trasc deleted the admitted-event branch December 14, 2023 17:10
trasc added a commit to epam/kubernetes-kueue that referenced this pull request Dec 14, 2023
…tes-sigs#1436)

* Use different events for QuotaReservation and Admission

* Review Remarks

* Review Remarks

* Review Remarks
k8s-ci-robot pushed a commit that referenced this pull request Dec 14, 2023
…1458)

* Use different events for QuotaReservation and Admission

* Review Remarks

* Review Remarks

* Review Remarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admitted event reported when only quota is reserved
5 participants