-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required RBAC on integration finalizers sub-resources #1486
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Hi @astefanutti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@astefanutti Could you update helm charts as well?
@tenzen-y thanks for the quick review! I've updated the Helm charts. |
/cherry-pick release-0.5 |
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@astefanutti Can you perform |
@tenzen-y I fail to find any error to fix. It seems more related to the flake tests reported in #1372? |
Oops, I have seen old CI logs. That's right. /lgtm |
LGTM label has been added. Git tree hash: d49e8fea2a095d38b80ba8556818c5ac3cc43b38
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tenzen-y: new pull request created: #1488 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.5 |
@tenzen-y: new pull request created: #1505 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Due to ordering of manifests, we could not create a cherry-pick PR: @astefanutti Can you manually open a cherry-pick PR? |
/release-note-edit
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1485
Special notes for your reviewer:
Does this PR introduce a user-facing change?